Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCSH - Cannot exit via CTRL+C #3355

Open
ce-bo opened this issue Aug 3, 2023 · 4 comments
Open

CCSH - Cannot exit via CTRL+C #3355

ce-bo opened this issue Aug 3, 2023 · 4 comments
Labels
blocked The issue or feature is blocked on another issue or PR that has to be resolved first bug Only issues that describe bugs. pr-analysis Issues that touch the analysis pr(oject). priority:high Set by PO UX / UI Everything related to design and user experience

Comments

@ce-bo
Copy link
Collaborator

ce-bo commented Aug 3, 2023

Bug

Expected Behavior

WHEN
I run ccsh command in my shell and enter CTRL+C to stop the command

THEN
I want the command to be exited

Actual Behavior

Nothing happens, I am stuck.

Screenshots

Steps to Reproduce the Problem

Specifications

  • is released in online-demo: yes | no
  • CodeCharta Version: 1.119.0
  • OS: Windows (cmd.exe, powershell, but not git bash).
  • Browser: -
@ce-bo ce-bo added bug Only issues that describe bugs. pr-analysis Issues that touch the analysis pr(oject). priority:high Set by PO UX / UI Everything related to design and user experience labels Aug 3, 2023
@moritz-suckow-mw
Copy link
Collaborator

I took a look at it and this seems to be correlated to KotlinInquirer. KInquirer uses Jline3 to handle console input in a rather old version (3.21.0). There was a very similar issue to this one at Jline3 (jline/jline3#822) which was closed and might have fixed the problem. Since then two new versions of Jline3 were released, but KotlinInquirer did not update their dependency.
I am unsure if we can fix this from our side.

@fritschldwg
Copy link
Contributor

fritschldwg commented Jan 5, 2024

Follow up on the previous comment after cloning the kotlin-inquirer repo:

  • Just updating jline to 3.23+ doesn't fix the issue on Windows. Control-C still propagates to the kotlin-inquirer and causes errors, but can be fixed with little code changes.
  • Since it's unlikely that any PRs will be merged into the kotlin-inquirer repo (some from 2022 are still open), we could use a fork in codecharta (kotlin-inquirer is used via jitpack in codecharta). This would also let us fix backspacing in gitbash, which currently doesn't work.

@fritschldwg
Copy link
Contributor

fritschldwg commented Jan 8, 2024

We could use one of the following solutions to address the shortcomings of the kotlin-inquirer:

  • Use alternatives to the kotlin-inquirer
    • There are no direct alternatives to the kotlin-inquirer and extandable cli-libraries like kotlinx-cli (https:/Kotlin/kotlinx-cli) are unmaintained
  • Fork the kotlin-inquirer repository and make necessary modifications
    • Fork is not wanted
  • Develop our own inquirer-library
  • Incorporate a java-inquirer into our project
    • java alternatives like text-io (https:/beryx/text-io) are unmaintained (last contributions often > 10 years)

@ce-bo
Copy link
Collaborator Author

ce-bo commented Jan 25, 2024

I think this is blocked by #3483

@ce-bo ce-bo added the blocked The issue or feature is blocked on another issue or PR that has to be resolved first label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked The issue or feature is blocked on another issue or PR that has to be resolved first bug Only issues that describe bugs. pr-analysis Issues that touch the analysis pr(oject). priority:high Set by PO UX / UI Everything related to design and user experience
Projects
None yet
Development

No branches or pull requests

3 participants