Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multi poly with rects #1999

Merged
merged 1 commit into from
May 30, 2022
Merged

fix multi poly with rects #1999

merged 1 commit into from
May 30, 2022

Conversation

SimonDanisch
Copy link
Member

poly([Rect2f(0, 0, 1, 1)], color=:green, strokewidth=2, strokecolor=:black) was missing a linesegment, since it was using the scatter conversion pipeline.

@MakieBot
Copy link
Collaborator

MakieBot commented May 30, 2022

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt.

using time

master:  9.94 < 10.05 > 10.29, 0.13+-
pr:      10.02 < 10.15 > 10.24, 0.07+-
speedup: 0.97 < 1.00 > 1.01, 0.01+-
median:  +0.98% => invariant

This PR does not change the using time.

ttfp time

master   28.78 < 28.99 > 29.31, 0.19+-
pr       28.82 < 29.14 > 29.62, 0.28+-
speedup: 0.99 < 1.00 > 1.00, 0.01+-
median:  +0.51% => invariant

This PR does not change the ttfp time.

@SimonDanisch SimonDanisch reopened this May 30, 2022
@SimonDanisch SimonDanisch merged commit ba7e31f into master May 30, 2022
@SimonDanisch SimonDanisch deleted the sd/fix-stroke-multi-rect branch May 30, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants