-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement MaxEncodedLen
wherever necessary
#387
Labels
A-runtime
Area: Issues and PRs related to Runtimes
C-good-first-issue
Category: Good first issues
P-medium
Priority: Medium
Milestone
Comments
ghzlatarev
changed the title
Implement MaxEncodedLen wherever necessary
Implement Feb 7, 2022
MaxEncodedLen
wherever necessary
Since this work is also underway in Praity repos there are many PRs to study like https:/paritytech/cumulus/pull/1337/files . Therefore it can also be good for first issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-runtime
Area: Issues and PRs related to Runtimes
C-good-first-issue
Category: Good first issues
P-medium
Priority: Medium
currently
without_storage_info
is used in all Pallets that do not implementMaxEncodedLen
paritytech/substrate#10662
Essentially
without_storage_info
means that the storage consumption of this pallet is unbounded.As part of this big PoV benchmarking issue paritytech/polkadot-sdk#398, they added a trait StorageInfoTrait that every storage should implement (on condition that value and keys implement MaxEncodedLen) paritytech/substrate#8735
Originally you had to use the generate_storage_info attribute to make a pallet implement the StorageInfoTrait. Since this shouldn't be missed in new pallets they made it implement by default, but now keys and values that don't implement MaxEncodedLen will not compile. So the without_storage_info attribute is used to skip implementation of StorageInfoTrait until MaxEncodedLen is implemented wherever necessary. paritytech/substrate#10662
Enabling this will allow us to adopt the following test:
paritytech/substrate#11699
The text was updated successfully, but these errors were encountered: