-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add manta docker image to publish #1243
Conversation
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
✅ Congestion test: 1-day congestion cost (manta-runtime) is above the target daily congestion cost |
|
@ferrell-code let's figure out the /latest image before we merge this. |
It makes the image created by this action the latest tag too. Not fool proof but that is way action works for calamari. Manta/.github/workflows/docker.yml Line 27 in 2bdf944
|
oh yeah makes sense, I suppose can we put the |
It creates separate images for calamari and manta. So there can be two "latest" tags |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ (cc @ryanlin-tech @grenade )
Signed-off-by: Georgi Zlatarev <[email protected]>
6cf75bd
Description
Publish manta images to docker hub on release relates #1239
Before we can approve this PR for merge, please make sure that all the following items have been checked off:
L-
group to this PRA-
andC-
groups to this PRA-calamari
and/orA-manta
if your changes are meant for/impact either of these (CI depends on it)Files changed
in the Github PR explorer.Situational Notes:
BaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime
. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]
items to check for any.