-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v4.6.0 #1277
Release v4.6.0 #1277
Conversation
Signed-off-by: Dengjianping <[email protected]>
manta runtime metadata diff result: [Spec] name: manta
|
calamari runtime metadata diff result: [Spec] name: calamari
|
We have problem on diffing runtime metatada, I failed to reproduce it locally. I created an issue to track it #1278, so won't fix it in this release. And I posted all diff result above, and the result shows we have to bump tx version(already bumped). |
Didn't we update the weights in the last PR ? Or do we need to do it again ? One of yesterday's runs succeeded though but not sure if its Manta or Calamari https:/Manta-Network/Manta/actions/runs/7262536984 |
No, those weights are generated from my computer. Yeah, it succeeded, but benchmark machine failed, I asked Ana to check it again, ensure we don't use low performance computer to benchmark our runtime. |
Lower's better than higher, but it also didn't benchmark one of the xcm modules for some reason. |
Signed-off-by: Dengjianping <[email protected]>
I'd just use the newly generated weights, so we can move this along. It's fine if the machine is less beefy compared to before. |
Signed-off-by: Dengjianping <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Description
Closes #1276
Before we can approve this PR for merge, please make sure that all the following items have been checked off:
L-
group to this PRA-
andC-
groups to this PRA-calamari
and/orA-manta
if your changes are meant for/impact either of these (CI depends on it)Files changed
in the Github PR explorer.A-integration-test-checks
to run start-integration-test-checks (Required)A-benchmark-checks
to run start-benchmark-check (Required)A-unit-test-checks
to run start-unit-test-checks (Required)A-congestion-test-checks
to run start-integration-test-checks (Optional)Situational Notes:
BaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime
. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]
items to check for any.