Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[manta] Adjust treasury and preimage pallets' deposits #406

Merged
merged 2 commits into from
Feb 22, 2022

Conversation

ghzlatarev
Copy link
Contributor

@ghzlatarev ghzlatarev commented Feb 17, 2022

Description

partially closes: #386
split from discussion in #377

  • Increased pallet_treasury's ProposalBondMaximum to 10k KMA.. The point of this constant is to not discourage people from proposing large expenditures. In dollar value this is ~100USD which is an arbitrary choice but seems good enough for now.
  • Increased pallet_treasury's ProposalBondMinimum to 500 KMA. The old value of 50 KMA is less than a dollar, which seems inappropriate.
  • Increased pallet_preimage's PreimageBaseDeposit to 1k KMA. This is not a DDoS vector, just another arbitrary choice since the previous value of 1 KMA was much lower than other chains.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (manta or dolphin) with right title (start with [Manta] or [Dolphin]),
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests.
  • Updated relevant documentation in the code.
  • Re-reviewed Files changed in the Github PR explorer.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. If this number is updated, then the spec_version must also be updated
  • If needed, notify the committer this is a draft-release and a tag is needed after merging the PR.
  • Verify benchmarks & weights have been updated for any modified runtime logics
  • If needed, bump version for every crate.
  • If import a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are offcially used by exchanges or community developers.
  • If we're going to issue a new release, freeze the code one week early(it depends, but usually it's one week), ensure we have enough time for related testing.
  • Check if inheriting any upstream runtime storage migrations. If any, perform tests with try-runtime.

@ghzlatarev ghzlatarev requested review from Dengjianping, stechu and Garandor and removed request for Dengjianping February 17, 2022 19:01
@ghzlatarev ghzlatarev self-assigned this Feb 17, 2022
@ghzlatarev ghzlatarev added the A-runtime Area: Issues and PRs related to Runtimes label Feb 17, 2022
@ghzlatarev ghzlatarev added this to the v3.1.5 milestone Feb 17, 2022
@stechu stechu merged commit 2c317cd into manta Feb 22, 2022
@ghzlatarev ghzlatarev deleted the ghzlatarev/deposit-configs-1 branch March 9, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-runtime Area: Issues and PRs related to Runtimes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit deposit configurations in Manta/Calamari
3 participants