Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make component imports explicit by adding .vue extension #143

Closed
MikeEtlingerRM opened this issue Nov 30, 2021 · 0 comments · Fixed by #144
Closed

Make component imports explicit by adding .vue extension #143

MikeEtlingerRM opened this issue Nov 30, 2021 · 0 comments · Fixed by #144

Comments

@MikeEtlingerRM
Copy link
Contributor

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

We are migrating our Vue project to use ViteJS and one of the requirements is that Vue components must have explicit import extensions for Single File Components. That means the imports in this package break local development in that scenario.

I'm happy to put up a PR for this trivial change but let me know if you have any concerns.

Thanks!

Here is the diff that solved my problem:

diff --git a/node_modules/vue-functional-calendar/src/components/FunctionalCalendar.vue b/node_modules/vue-functional-calendar/src/components/FunctionalCalendar.vue
index dae7411..fc7a87a 100644
--- a/node_modules/vue-functional-calendar/src/components/FunctionalCalendar.vue
+++ b/node_modules/vue-functional-calendar/src/components/FunctionalCalendar.vue
@@ -217,13 +217,13 @@
 <script>
 import helpCalendarClass from '../assets/js/helpCalendar'
 import { propsAndData } from '../mixins/propsAndData'
-import TimePicker from '../components/TimePicker'
-import Arrows from '../components/Arrows'
-import WeekNumbers from '../components/WeekNumbers'
-import Day from '../components/Day'
-import MonthYearPicker from '../components/MonthYearPicker'
-import PickerInputs from '../components/PickerInputs'
-import Footer from '../components/Footer'
+import TimePicker from '../components/TimePicker.vue'
+import Arrows from '../components/Arrows.vue'
+import WeekNumbers from '../components/WeekNumbers.vue'
+import Day from '../components/Day.vue'
+import MonthYearPicker from '../components/MonthYearPicker.vue'
+import PickerInputs from '../components/PickerInputs.vue'
+import Footer from '../components/Footer.vue'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant