Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync mariadb version with prod #598

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Conversation

fauust
Copy link
Collaborator

@fauust fauust commented Oct 16, 2024

Was already deployed and tested on DEV.

The following was needed:

docker exec -it mariadb mysql_upgrade --force

@grooverdan
Copy link
Member

grooverdan commented Oct 16, 2024

MARIADB_AUTO_UPGRADE=1 and you won't need manual post steps.

https://mariadb.com/kb/en/using-healthcheck-sh/ for the healthcheck.

    depends_on:
      mariadb:
        condition: service_healthy

For dependent services (otherwise they start when mariadb starts, not when its ready).

MariaDB tuning, as command, if it gets unruly can move to a config file.

command: --slow_query_log --log_slow_verbosity=query_plan,explain,engine --log_slow_query_time=0.5 --innodb-buffer-pool-size=4G --innodb-log-file-size=4G --innodb_io_capacity=2000

@illuusio
Copy link
Contributor

illuusio commented Oct 17, 2024

Where does innodb_io_capacity = 2000 come from? Is it some calculated IOPS? As reading docs it's just something in the docs and if it's that high one needs to set innodb_io_capacity_max higher as it's default is 2000 also.

@illuusio
Copy link
Contributor

illuusio commented Oct 17, 2024

Shouldn't:

innodb-buffer-pool-size = 4G
innodb-log-file-size    = 4G

be

innodb_buffer_pool_size = 4G
innodb_log_file_size    = 4G

@fauust
Copy link
Collaborator Author

fauust commented Oct 17, 2024

https://mariadb.com/kb/en/using-healthcheck-sh/ for the healthcheck.

    depends_on:
      mariadb:
        condition: service_healthy

For dependent services (otherwise they start when mariadb starts, not when its ready).

So, do you think that https:/MariaDB/buildbot/blob/dev/docker-compose/start-bbm-web.sh#L21-L25 is overkill?

@grooverdan
Copy link
Member

Shouldn't:

innodb-buffer-pool-size = 4G
innodb-log-file-size    = 4G

be

innodb_buffer_pool_size = 4G
innodb_log_file_size    = 4G

both forms are accepted.

@grooverdan
Copy link
Member

Where does innodb_io_capacity = 2000 come from? Is it some calculated IOPS? As reading docs it's just something in the docs and if it's that high one needs to set innodb_io_capacity_max higher as it's default is 2000 also.

Mainly that the default of 200 was for some pretty old/poor storage and I assume we have better. Measuring would be better. I can't remember the behaviour of innodb_io_capacity_max off had but it might auto-adjust.

@illuusio
Copy link
Contributor

Shouldn't:

innodb-buffer-pool-size = 4G
innodb-log-file-size    = 4G

be

innodb_buffer_pool_size = 4G
innodb_log_file_size    = 4G

both forms are accepted.

Yes I know they are both accepted but this is bit like CMake use uppercase or lowercase in function names not both. All I was trying to say that it looks bit unfinished to have '_' and '-'.

@illuusio
Copy link
Contributor

illuusio commented Oct 18, 2024

Where does innodb_io_capacity = 2000 come from? Is it some calculated IOPS? As reading docs it's just something in the docs and if it's that high one needs to set innodb_io_capacity_max higher as it's default is 2000 also.

Mainly that the default of 200 was for some pretty old/poor storage and I assume we have better. Measuring would be better. I can't remember the behaviour of innodb_io_capacity_max off had but it might auto-adjust.

Seems so as I made bit IOPS testing and 2000 is easily what one get. Ok Max is 2000 or twice innodb_io_capacity, whichever is higher.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants