-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove .mbd / .mbdf
#1672
Comments
Context:
"pages": [
{
"glob": ["**/*.+(md|mbd)"]
} |
That makes sense. How about
? We can leave the definition of fragments to the user for more flexibility; or it can be defined on folder basis as well.
Is this for |
yes, that can work too. We can tweak the default site.json to exclude
Yup. |
I think this is fine if that's the case; A lot of the other ssgs out there don't have custom file extensions as well. I feel that familiarity (and default syntax highlighting) should take priority here.
I see, I might imagine someone might need to process canonical Even if not, I think we should be striving for familiarity and reducing markbind's complexity as these use cases are likely really rare.
🤣🤣 really really low probability imo. |
I almost never use |
👍 Let's do that then if there's no objections; But we can slate this for v4 in a few more months time since its a breaking change |
Assuming we do remove |
Just to be clear, after removing support for .mbd and mbdf, what's the best way to specify that I want all fragment files to be excluded from rendering.
|
Nope, its a breaking change
Something like |
Assuming we do remove .mbd and .mbdf users who are currently using these file names will have to go and rename them, would this be a big issue for the users? Or should the change still allow .mbd and .mbdf to exist? Can I use any extension I wish for such files, including .mbdf? I guess the answer is 'no'? Nope, its a breaking change If not, let's say I decide to use **-fragment.md pattern for such files. Is it possible to capture that into a single pagesExclude pattern? Asking because I'm not sure how flexible glob pattern syntax is. I don't think it's as flexible as regular expressions. Something like **/*-fragment.md should work Sounds good. Thanks for the clarification @ang-zeyu |
I've just tested this out and it works. I will be adding this feature under a |
I probably don't have the relevant context but this has been bugging me for a very long time now anyway =X
What's the purpose of these extra extensions?
.mbdf
is used to denote "fragment" but really other than that, it dosen't provide any concrete value. My opinion thus is that file organisation / hierarchy here is a responsibility that should be left to the user. There are already many cases where you would need to<include>
from a non.mbdf
file..mbd
files on the other hand don't really seem to have a use case.I don't think we should be reinventing the wheel when it comes to file extensions here and should just stick with the canonical default (
.md
), for familiarity.There's also the issue of syntax highlighting in ides that needs to be manually configured for
mbd / mbdf
files (which sometimes isn't even an option)*This is a huge breaking change of course.
The text was updated successfully, but these errors were encountered: