Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Inactive Groups in Submission Table #7000

Conversation

pranavrao145
Copy link
Contributor

@pranavrao145 pranavrao145 commented Mar 26, 2024

Motivation and Context

Similar to #6778, this PR hides inactive groups in the Submissions table by default and adds a toggle to show inactive groups if needed.

Your Changes

  • Made Submissions table hide inactive groups by default
  • Added a toggle to allow Instructors and TAs to see inactive groups if they wish
  • Minor bug fixes in relevant components, as revealed by attempting to write unit tests for them

Type of change (select all that apply):

  • New feature (non-breaking change which adds functionality)

Testing

  • Amended existing RSpec to account for minor change in the information sent by the server on a specific request.
  • Wrote a Jest test suite for the new front-end check box functionality

Checklist

  • I have performed a self-review of my own code.
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported on Coveralls.
  • I have added tests for my changes.
  • I have updated the Changelog.md file.

@pranavrao145 pranavrao145 force-pushed the feat/hide-inactive-groups-in-submissions-table branch 2 times, most recently from 0914ec8 to 0d7e93f Compare March 26, 2024 20:53
@pranavrao145 pranavrao145 marked this pull request as ready for review March 26, 2024 20:56
@coveralls
Copy link
Collaborator

coveralls commented Mar 27, 2024

Pull Request Test Coverage Report for Build 8493405351

Details

  • 23 of 24 (95.83%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 91.776%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/assets/javascripts/Components/submission_table.jsx 19 20 95.0%
Totals Coverage Status
Change from base Build 8487186587: -0.2%
Covered Lines: 39754
Relevant Lines: 42674

💛 - Coveralls

@pranavrao145 pranavrao145 force-pushed the feat/hide-inactive-groups-in-submissions-table branch from 9c2430a to 5c6ac21 Compare March 28, 2024 15:49
app/models/assignment.rb Outdated Show resolved Hide resolved
app/assets/javascripts/Components/submission_table.jsx Outdated Show resolved Hide resolved
@pranavrao145 pranavrao145 force-pushed the feat/hide-inactive-groups-in-submissions-table branch from 851f1e3 to bd096fa Compare March 30, 2024 21:08
@david-yz-liu david-yz-liu merged commit 2f4303e into MarkUsProject:master Mar 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants