-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Failure to compile in VSCode after making any changes to Configuration.h and Configuration_adv.h Files #26000
Comments
EITHER and BOTH macro was deliberately removed from Marlin bugfix after users complained there are to many macros that do that same thing. See #25908 Your Configs are out of date replace BOTH with ALL This Issue Queue is for Marlin bug reports and development-related issues, and we prefer not to handle user-support questions here. (As noted on this page.) For best results getting help with configuration and troubleshooting, please use the following resources:
After seeking help from the community, if the consensus points to a bug in Marlin, then you should post a bug report. |
I'll remember that in the future. I have no PC coding experience yet but as much similarity as it has with Fanuc Macro B, hopefully one day I'll actually get to help you guys out. Thanks for the quick and thorough reply. |
This makes absolutely no sense whatsoever, they are macros, so what if they are there, does it really matter? Ever heard of backward compatibility? instead you waste time on such trivial things, every revision constantly renaming defines, removing macros. It escapes me that you programmers have so much time on your hands to waste it on such trivial nonsense. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
@nicwilson58 — You could simply ask why the change was made rather than attacking us. If you would like to understand the rationale for this change, there is a discussion on the Marlin Discord about it. If you disagree with this change, please add your feedback to that discussion. |
Did you test the latest
bugfix-2.1.x
code?Yes, and the problem still exists.
Bug Description
I'm trying to configure Marlin-Bugfix-2.1.X for a BTT SKR Mini E3 V3 Board. I've got a lot of mods done to this printer and it requires a lot of changes to Configuration.h & Configuration_adv.h. If I simply compile the firmware without making any changes, it results in success. However, once a single change is made, I get a long list of errors pertaining to BOTH and EITHER statements. My research leads me to believe its a failure to define EITHER and BOTH in Marlin/src/core/macros.h. In the macros.h file placing #define EITHER(V1,V2) ANY(V1,V2) and recompiling, results in only having errors for BOTH statements shown below. Can Someone show me a way to define BOTH(V1,V2) in that folder that could result in a successful compile. Perhaps this would be a worthwhile addition to the folder if this is the actual problem. I greatly appreciate your time.
Configuration.zip
Configuration_adv.zip
macros.zip
Some of the changes I made
Errors while trying to configure,
Placing #define EITHER(V1,V2) ANY(V1,V2) on line between #define ANY and #define All will remove all of my missing binary operator before token "(" problems on EITHER statement lines.
Bug Timeline
First time compiling marlin. No prior experience.
Expected behavior
Successful Compile
Actual behavior
Failure to Compile
Steps to Reproduce
Version of Marlin Firmware
Marlin-Bugfix-2.1.X
Printer model
Creality Ender 3 Pro
Electronics
BTT SKR Mini E3 V3.0
Add-ons
TFT35, E3D V6, CR Touch Probe, Belted Z,
Bed Leveling
None
Your Slicer
Cura
Host Software
Pronterface
Don't forget to include
Configuration.h
andConfiguration_adv.h
.Additional information & file uploads
No response
The text was updated successfully, but these errors were encountered: