Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M109 & M190 with no or wrong parameters #6308

Closed
Tannoo opened this issue Apr 11, 2017 · 5 comments
Closed

M109 & M190 with no or wrong parameters #6308

Tannoo opened this issue Apr 11, 2017 · 5 comments
Labels
Bug: Confirmed ! S: Solved

Comments

@Tannoo
Copy link
Contributor

Tannoo commented Apr 11, 2017 •
edited by thinkyhead
Loading

This causes Marlin to think it's heating, but the heaters do not come on due to no temperature set.
Marlin is then waiting for the temperature to get to an unknown temp without turning on the heaters.
It does timeout, but is it simulating the dryrun that's not enabled?

This needs to error out saying no temp set or something to that effect.

M109 Log Output 
echo:M109
 T:18.7 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.7 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.7 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.7 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.7 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.7 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.7 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.7 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.7 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.7 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.7 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.7 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.7 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.7 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.7 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.7 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.6 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.7 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.7 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.7 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.6 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.7 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.7 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.7 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.6 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.5 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.6 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.5 /0.0 B:22.4 /0.0 @:0 B@:0 W:?
 T:18.6 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.4 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.6 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.6 /0.0 B:22.4 /0.0 @:0 B@:0 W:?
 T:18.4 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.5 /0.0 B:22.4 /0.0 @:0 B@:0 W:?
 T:18.6 /0.0 B:22.2 /0.0 @:0 B@:0 W:?
 T:18.4 /0.0 B:22.5 /0.0 @:0 B@:0 W:?
 T:18.4 /0.0 B:22.3 /0.0 @:0 B@:0 W:?
 T:18.4 /0.0 B:22.1 /0.0 @:0 B@:0 W:?
 T:18.3 /0.0 B:22.2 /0.0 @:0 B@:0 W:?
 T:18.4 /0.0 B:22.2 /0.0 @:0 B@:0 W:?
 T:18.2 /0.0 B:22.1 /0.0 @:0 B@:0 W:?
 T:18.3 /0.0 B:22.2 /0.0 @:0 B@:0 W:?
 T:18.4 /0.0 B:22.1 /0.0 @:0 B@:0 W:?
 T:18.4 /0.0 B:22.1 /0.0 @:0 B@:0 W:?
 T:18.3 /0.0 B:22.1 /0.0 @:0 B@:0 W:?
 T:18.4 /0.0 B:22.0 /0.0 @:0 B@:0 W:?
 T:18.3 /0.0 B:22.0 /0.0 @:0 B@:0 W:?
 T:18.2 /0.0 B:22.0 /0.0 @:0 B@:0 W:?
 T:18.3 /0.0 B:21.9 /0.0 @:0 B@:0 W:?
 T:18.3 /0.0 B:21.9 /0.0 @:0 B@:0 W:?
 T:18.3 /0.0 B:21.9 /0.0 @:0 B@:0 W:?
 T:18.3 /0.0 B:21.9 /0.0 @:0 B@:0 W:?
 T:18.2 /0.0 B:21.9 /0.0 @:0 B@:0 W:?
 T:18.2 /0.0 B:21.9 /0.0 @:0 B@:0 W:?
 T:18.2 /0.0 B:21.9 /0.0 @:0 B@:0 W:?
 T:18.3 /0.0 B:21.9 /0.0 @:0 B@:0 W:?
 T:18.2 /0.0 B:21.9 /0.0 @:0 B@:0 W:?
 T:18.2 /0.0 B:21.9 /0.0 @:0 B@:0 W:?
 T:18.1 /0.0 B:21.9 /0.0 @:0 B@:0 W:?
 T:18.1 /0.0 B:21.9 /0.0 @:0 B@:0 W:?
ok
M190 Log Output 
echo:M190
 T:17.9 /0.0 B:20.2 /0.0 @:0 B@:0 W:?
 T:18.0 /0.0 B:20.3 /0.0 @:0 B@:0 W:?
 T:18.0 /0.0 B:20.1 /0.0 @:0 B@:0 W:?
 T:18.0 /0.0 B:20.2 /0.0 @:0 B@:0 W:?
 T:17.9 /0.0 B:20.3 /0.0 @:0 B@:0 W:?
 T:17.9 /0.0 B:20.2 /0.0 @:0 B@:0 W:?
 T:18.0 /0.0 B:20.1 /0.0 @:0 B@:0 W:?
 T:18.1 /0.0 B:20.1 /0.0 @:0 B@:0 W:?
 T:17.9 /0.0 B:20.2 /0.0 @:0 B@:0 W:?
 T:18.0 /0.0 B:20.1 /0.0 @:0 B@:0 W:?
 T:17.9 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.9 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.9 /0.0 B:20.1 /0.0 @:0 B@:0 W:?
 T:18.0 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.9 /0.0 B:20.1 /0.0 @:0 B@:0 W:?
 T:17.9 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.9 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.8 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:18.0 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.9 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.9 /0.0 B:20.1 /0.0 @:0 B@:0 W:?
 T:17.7 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.9 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:18.0 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.8 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.8 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.9 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.8 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.8 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.9 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.8 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.9 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.8 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.7 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.8 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.8 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.9 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.9 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.8 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.8 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.8 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.7 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.8 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.7 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.7 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.7 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.8 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.8 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.7 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.7 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.8 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.7 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.7 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.7 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.6 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.7 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.7 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.8 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.7 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
 T:17.5 /0.0 B:20.0 /0.0 @:0 B@:0 W:?
ok
@Tannoo Tannoo changed the title M109 & M190 with no parameters M109 & M190 with no or wrong parameters Apr 11, 2017
@thinkyhead
Copy link
Member

thinkyhead commented Apr 11, 2017 •
edited
Loading

I've checked the "specification" — the description on the RepRap wiki — and it says that M109 and M190 don't do anything without an S or R parameter. So I'll just make it bounce if neither of these parameters is included.

Alternatively, without parameters these could just take the current target temperature and go with that, making M109 / M190 alone into simple "wait for current target temperature to be reached" commands.

@Tannoo
Copy link
Contributor Author

Tannoo commented Apr 11, 2017

I would make it bounce.

@thinkyhead
Copy link
Member

Bounce it is!

@thinkyhead thinkyhead mentioned this issue Apr 11, 2017
Merged
@Tannoo
Copy link
Contributor Author

Tannoo commented Apr 11, 2017

Fixed with PR #6311.

@Tannoo Tannoo closed this as completed Apr 11, 2017
@cheton cheton mentioned this issue Nov 11, 2017
Closed
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug: Confirmed ! S: Solved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thinkyhead @Tannoo