Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more response validation #16

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

pnadolny13
Copy link
Contributor

@pnadolny13 pnadolny13 commented Nov 16, 2022

Closes #15

This looks to be working so far but the tests fail even with a valid API key. I suspect that it was failing before but the errors were suppressed. Patching those requests would probably fix it.

@pnadolny13 pnadolny13 changed the title add more response validation, tests fail though add more response validation Nov 16, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse Response For Errors
1 participant