New vignette for sim_fixed_n() in parallel #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a new vignette to show users how to set up the backend topologies for parallel runs of sim_fixed_n(). The schema.png is included in the vignette.
editing vignette index entry
adding parallel to the articles to fix pkgdown data_articles_index() call not finding new vignette
nanxstats
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Very well written vignette! I made some minor improvements on code style. I think this is ready for merge.
We may consider two things in the future:
-
Restrict to using maximum 2 cores to ensure CRAN check compliance.
GitHub Actions runners use 2-core or 3-core VMs so the pkgdown site should render with proper parallel results.
-
Make the language more generic as we expand the native parallelization availability beyond
sim_n_fixed().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new vignette to show users how to set up the backend topologies for parallel runs of sim_fixed_n(). The schema.png is included in the vignette.