-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add age of air diagnostic functionality #480
base: main
Are you sure you want to change the base?
Conversation
Tests to do include;
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some vague review comments. I've not properly read through and understood the code yet though. I'll do that a bit later.
thanks! There is a lot more to add yet, this is mostly initial commits for copy/pasting code into CSET. So best to hold of any review, as code needs a lot of tidying up/documentation, plus all the testing and cylc/yaml additions |
Got a bit eager, but its great to see it coming along. I'll mark this PR as a draft for now. |
Meta
YAML
Cycling
20240417T0000Z So all pressure levels run in parallel. |
Note that there are other suggestions that GitHub has hidden under "hidden conversations". You might be better off looking through the Files tab for them. |
I think the design of this operator needs some consideration with how it will work with the current default of CSET of cycling through valid-time. The operator expects to be run once, for a given initialisation, and passed all the data for that forecast. I don't really know how compatible this is with the current architecture, because each calculation at each forecast time depends on the preceding data. |
For now this can be worked around by running the operator within the collate step. We are currently discussing a longer term change to cycling on data time, which would alleviate this. |
Extracts data required for, and calculates the age of air diagnostic on a given pressure levels. This is then plotted on a map projection for each lead-time. A timeseries plot is also produced. | ||
|
||
parallel: | ||
- operator: read.read_cubes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to be filtering on validity time
Adding capability to run the age of air diagnostic on data, linked to issue #269