-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to data time cycling to support multiple models and multiple case studies or trials #765
Open
jfrost-mo
wants to merge
92
commits into
main
Choose a base branch
from
750_data_time_cycling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfrost-mo
force-pushed
the
750_data_time_cycling
branch
from
August 1, 2024 08:23
875fb6b
to
e89544e
Compare
jfrost-mo
force-pushed
the
750_data_time_cycling
branch
from
August 6, 2024 09:58
053fe11
to
9567afb
Compare
jfrost-mo
changed the title
Switch to datetime cycling, support multiple models, etc.
Switch to data time cycling, support multiple models, etc.
Aug 8, 2024
jfrost-mo
force-pushed
the
750_data_time_cycling
branch
from
August 12, 2024 12:45
6f8722f
to
20a014d
Compare
7 tasks
jfrost-mo
force-pushed
the
750_data_time_cycling
branch
3 times, most recently
from
August 22, 2024 09:53
2133d21
to
d6b08fe
Compare
jfrost-mo
force-pushed
the
750_data_time_cycling
branch
from
August 22, 2024 14:56
8db71ca
to
3eafb43
Compare
jfrost-mo
force-pushed
the
750_data_time_cycling
branch
from
August 23, 2024 06:53
c48d075
to
2636cf0
Compare
This was referenced Aug 23, 2024
jfrost-mo
force-pushed
the
750_data_time_cycling
branch
4 times, most recently
from
August 23, 2024 15:47
b1d6ab6
to
62ec811
Compare
jfrost-mo
changed the title
Switch to data time cycling, support multiple models, etc.
Switch to data time cycling to support multiple models and multiple case studies or trials
Aug 23, 2024
jfrost-mo
force-pushed
the
750_data_time_cycling
branch
from
August 27, 2024 08:14
104765a
to
8a1a8fe
Compare
This work is now ready to be reviewed. |
jfrost-mo
requested review from
SGallagherMet,
JorgeBornemann and
Sylviabohnenstengel
August 27, 2024 15:37
This is useful if the setting is not in the rose-suite.conf
Also add a test.
The output_dir was in the wrong place, so it was making a POST request.
This prevents needing to rely on external hosts for these. I did need to drop the example commands to fetch the resources via curl, but they were probably confusing anyway.
They are not implemented yet, and can be re-added when they are.
The operator now requires all arguments to either be numbers, or all be None if you don't want to constrain the area. The test has been mildly improved, so at least it checks for both of the named functions on the coordinates, though it still doesn't test that they do anything.
It is invalid rose syntax. Also use !! to disable showing the option in the GUI.
jfrost-mo
force-pushed
the
750_data_time_cycling
branch
from
September 27, 2024 03:38
28a9e02
to
64da0c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
full_review
Requires a technical, scientific, and portability review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #750
WIP in title is just to stop accidental merge before all three reviews.
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.
GitHub Copilot was used in the PR.