Remove unwanted single returns from arrow functions

[darkwing]

This is a code styling proposal to remove unnecessary return statements inside arrow functions when we could use the implied return. For example:

// from ...
const j = () => {
  return 1;
};

// to....
const je = () => 1;

The real work is arrow-body-style: 1 in our ESLint config -- the rest of these changes are done via yarn lint --fix.

Thoughts?

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[mcmire]

In general I like this change but there are cases where this can reduce readability IMO, so I'm slightly 👎🏻 . Not a big deal though if others feel differently.

[mcmire]

I feel like in cases like this, the braces can help with readability.

[mcmire]

Same thing with this. It's not impossible to know where the function begins and ends, of course, because of the indentation, but the braces help in being able to spot it more easily.

[rekmarks]

Can we use strings instead of numbers here? We've been trying to avoid using numbers so we don't have to remember what they mean.

[darkwing]

I tried 'error' but for some reason the linting bombed, requesting a number. I'll look into it, it was weird.

[rekmarks]

Update: We can't have nice things: MetaMask/eslint-config#205 (comment)

[brad-decker]

I'm in favor of this change. I do see @mcmire 's point on readability in some cases, but in my opinion, it can be generally more readable in more circumstances than it is less. The lack of bracket is a clear indication that the function simply returns whatever follows, and doesn't contain any logic of its own. This is my experience, others may feel differently and should voice their opinions.

Also, at what point does it make sense to elevate this to the eslint config repo?

[jpuri]

Agree with @darkwing , @brad-decker : to me also this is more readable and kind of simplified. I always prefer not to have brackets around arrow functions whenever possible.

[darkwing]

Closing for upstream MetaMask/eslint-config#205