Don't show ledger live option in advanced settings if using firefox

[danjm]

Addresses an issue found during QA of v10.4.0

Ledger Live doesn't work with firefox, so this option should not be selected in the advanced tab of settings when on firefox. This is how it works on prod.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [9f04aef]

• builds: chrome, firefox, opera
• build viz: Build System
• code coverage: Report
• storybook: Storybook
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • phishing-detect: phishing-detect
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 2, 3, 4, 5

Page Load Metrics (462 ± 65 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	87	875	440	157	75
		domContentLoaded	344	876	448	138	66
		load	360	876	462	136	65
		domInteractive	344	876	448	138	66

highlights:

storybook

• ui/pages/settings/advanced-tab/advanced-tab.stories.js

[NiranjanaBinoy]

LGTM

[darkwing]

Do we want to go a step further and only allow U2f if it's Firefox? Mozilla refuses to implement WebHID: mozilla/standards-positions#459

[danjm]

@darkwing WebHID won't display on firefox because of this part: https:/MetaMask/metamask-extension/pull/12494/files#diff-f94eef96c77b5b32a219eb3b2ddb3700d6dd52d265e4d8a80da95117e21ace8fL423-L428

[Gudahtt]

It does seem silly to include a dropdown with only one entry. I hope we'll have more options in the future, but removing it makes sense for now.

[danjm]

As of the latest commit, the dropdown is just hidden when using firefox

[metamaskbot]

Builds ready [84575f0]

• builds: chrome, firefox, opera
• build viz: Build System
• code coverage: Report
• storybook: Storybook
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • phishing-detect: phishing-detect
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 2, 3, 4, 5

Page Load Metrics (292 ± 9 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	276	362	294	19	9
		domContentLoaded	267	348	284	19	9
		load	276	360	292	19	9
		domInteractive	267	348	284	19	9

highlights:

storybook

• ui/pages/settings/advanced-tab/advanced-tab.stories.js

[ryanml]

nit: only if you have to push again, can we group the constant and helper imports together in the top of the file?