Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(1702): enhanced onboarding settings config #11127

Merged
merged 39 commits into from
Oct 9, 2024
Merged

feat(1702): enhanced onboarding settings config #11127

merged 39 commits into from
Oct 9, 2024
+1,705 −201

Conversation

vinnyhoward
Copy link
Contributor

@vinnyhoward vinnyhoward commented Sep 10, 2024 •
edited
Loading

Description

This PR enhances the onboarding experience by allowing users to configure key settings before accessing their wallet. This change aims to improve user control and understanding of the app's features from the outset. Some copy was also added or changed

New Screens

Added the following screens to the OnboardingSuccessFlow:

  • OnboardingGeneralSettings
  • OnboardingAssetsSettings
  • OnboardingSecuritySettings

Related issues

Feature: #1702

Manual testing steps

  1. Fresh install application
  2. Create/import new wallet
  3. Success screen will appear with the title "Your Wallet is ready" and below the title and description, click on the text that says "Manage default settings"
  4. You will be routed to the onboarded settings screen with the options General, Assets, and Security

Screenshots/Recordings

Before After
before after

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinnyhoward vinnyhoward force-pushed the feat-1702-enhance-onboarding-settings-config branch 2 times, most recently from 13317a7 to 08234ab Compare September 11, 2024 15:01
@vinnyhoward vinnyhoward force-pushed the feat-1702-enhance-onboarding-settings-config branch from 2aaea6c to 92e2f3a Compare September 12, 2024 21:36
@vinnyhoward vinnyhoward added the Run Smoke E2E Triggers smoke e2e on Bitrise label Sep 12, 2024
@vinnyhoward vinnyhoward marked this pull request as ready for review September 12, 2024 22:37
@vinnyhoward vinnyhoward requested a review from a team as a code owner September 12, 2024 22:37
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 12, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 94fa19b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f628d8d1-8060-4323-bb11-049c8d6bb5c7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 16, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: edbb82e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3bd871f1-3c18-4859-b14e-5b69de5b3f8c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward dismissed EtherWizard33’s stale review October 7, 2024 18:35

Decided to postpone refactoring the Advanced Security Settings component into TS in favor of Q4 objectives

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 1cdd534
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b1877329-546a-4c1f-af51-ef3d2254dd03

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: cdbc16d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cc907c02-c037-40fb-987d-fe5ef6a2f0f4

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: bb29b36
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b71f2f73-e0b5-44c4-843c-720735512e8f

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7808d51
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b011ae37-f146-4d60-b1b8-5137b4b29264

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 7, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
73.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@EtherWizard33 EtherWizard33 self-requested a review October 7, 2024 20:19
georgewrmarshall
georgewrmarshall approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great use of design system components, excellent PR description and the PR size is much more manageable. Removing additional styling also improves consistency, in my opinion. Nice work! 💯 I didn't run locally so please get review from the other listed reviewers with mobile focus before merging 🙏

@vinnyhoward vinnyhoward added this pull request to the merge queue Oct 7, 2024
@vinnyhoward vinnyhoward removed this pull request from the merge queue due to a manual request Oct 7, 2024
Jonathansoufer
Jonathansoufer approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@Jonathansoufer Jonathansoufer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work on improving user experience.

@vinnyhoward vinnyhoward added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit 464fcac Oct 9, 2024
42 of 43 checks passed
@vinnyhoward vinnyhoward deleted the feat-1702-enhance-onboarding-settings-config branch October 9, 2024 21:06
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

@Jonathansoufer Jonathansoufer Jonathansoufer approved these changes

@EtherWizard33 EtherWizard33 EtherWizard33 approved these changes

@tommasini tommasini tommasini left review comments

Assignees
No one assigned
Labels
release-7.34.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vinnyhoward @codecov-commenter @EtherWizard33 @georgewrmarshall @Jonathansoufer @tommasini @gauthierpetetin