Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix multi rpc modal design #11720

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Oct 9, 2024

Description

fix design ui for the multi rpc modal

Related issues

Fixes:

Manual testing steps

  1. this Modal is not called yet , it's require the network controller v21 to be used
  2. the use of this modal will be done on this PR

Screenshots/Recordings

Before

After

Screenshot 2024-10-04 at 11 44 15

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb requested review from a team as code owners October 9, 2024 20:38
Copy link
Contributor

github-actions bot commented Oct 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb force-pushed the salim/fix-multi-rpc-modal-design branch from 1eb2b07 to 7e38ed2 Compare October 9, 2024 20:41
@salimtb salimtb added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7e38ed2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f4d462df-c8af-49b1-ac4a-4827f12f105b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Oct 9, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant