Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap for GraphQL 15 #594

Closed
iamchathu opened this issue Apr 3, 2020 · 5 comments
Closed

Roadmap for GraphQL 15 #594

iamchathu opened this issue Apr 3, 2020 · 5 comments
Assignees
Labels
Community 👨‍👧 Something initiated by a community Enhancement 🆕 New feature or request Solved ✔️ The issue has been solved
Milestone

Comments

@iamchathu
Copy link

iamchathu commented Apr 3, 2020

Is your feature request related to a problem? Please describe.
Any update for GraphQL version 15 support. Currently give error for not supported GraphQL version

UnhandledPromiseRejectionWarning: Error: Looks like you use an incorrect version of the 'graphql' package: "15.0.0". Please ensure that you have installed a version that meets TypeGraphQL's requirement: "^14.1.1".

Describe the solution you'd like
Update on Roadmap towards GraphQL new version.

@MichalLytek
Copy link
Owner

I need to go through all the breaking changes and fixes, adjust the code appropriately and fix all the encountered issued:
https:/graphql/graphql-js/releases

Don't expect this to be backported to 0.17.x branch - this will be a part of a major v1.0.0 release 😉

@MichalLytek MichalLytek added Community 👨‍👧 Something initiated by a community Enhancement 🆕 New feature or request labels Apr 3, 2020
@MichalLytek MichalLytek self-assigned this Apr 3, 2020
@MichalLytek MichalLytek added this to the 1.0.0 release milestone Apr 3, 2020
@iamchathu
Copy link
Author

Seems there is lot breaking changes and understand it will take time to co with it. But love to see it added to 1.0 release. Seems my Lerna setup added it as project dependancy. After removing it the error is gone.

@MichalLytek
Copy link
Owner

MichalLytek commented Apr 4, 2020

The first issue I've encountered is this bug:
graphql/graphql-js#2504

Based on the experience with v14, it gonna takes a few weeks or longer to update all other libraries like apollo libraries to work with v15. For now it's 10+ peer dependencies error on install.

Work in progress is available in https:/MichalLytek/type-graphql/tree/graphql-js-v15

@MohammedALREAI
Copy link

try to remove graphql by yarn remove graphql and install it again with version "graphql": "^14.1.1",

yusunglee2074 added a commit to yusunglee2074/jedal-be that referenced this issue May 2, 2020
type-grapqhl이 15버전을 지원 예정이나 아직 마이그레이션이 안됬습니다.
MichalLytek/type-graphql#594
@MichalLytek
Copy link
Owner

As no response from graphql-js maintainers, I gonna move forward and re-enable that failing test case later, when they release a patch for that.

So closing via a67c3af 🔒 Available in 1.0.0-rc.1 release 😉

@MichalLytek MichalLytek added the Solved ✔️ The issue has been solved label May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community 👨‍👧 Something initiated by a community Enhancement 🆕 New feature or request Solved ✔️ The issue has been solved
Projects
None yet
Development

No branches or pull requests

3 participants