Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more options for array with nullable element #119 #211

Merged
merged 3 commits into from
Dec 22, 2018
Merged

Add more options for array with nullable element #119 #211

merged 3 commits into from
Dec 22, 2018

Conversation

kenpusney
Copy link
Contributor

This is to add new options for nullable to resolve issue #119

@codecov
Copy link

codecov bot commented Dec 6, 2018

Codecov Report

Merging #211 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
+ Coverage   95.39%   95.48%   +0.08%     
==========================================
  Files          60       62       +2     
  Lines         978      996      +18     
  Branches      169      175       +6     
==========================================
+ Hits          933      951      +18     
  Misses         44       44              
  Partials        1        1
Impacted Files Coverage Δ
src/errors/ConflictingDefaultWithNullableError.ts 100% <100%> (ø)
src/helpers/types.ts 96% <100%> (+1%) ⬆️
src/errors/index.ts 100% <100%> (ø) ⬆️
src/errors/WrongNullableListOptionError.ts 100% <100%> (ø)
src/schema/schema-generator.ts 97.1% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c740d1f...470cb58. Read the comment docs.

Copy link
Owner

@MichalLytek MichalLytek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution! ❤️
Please tweak some things pointed in review and also add a proper info about this options in docs 😉

src/decorators/types.ts Outdated Show resolved Hide resolved
src/helpers/types.ts Outdated Show resolved Hide resolved
tests/functional/resolvers.ts Show resolved Hide resolved
@MichalLytek
Copy link
Owner

@kenpusney
Are you going to finish this up or should I checkout your branch and add some changes there?
We have to also add a proper info about this options in docs 📝

@kenpusney
Copy link
Contributor Author

@19majkel94
sorry get lost in massive work, possibly have no enough time to finish this. Please do help if you can, thanks.

@MichalLytek MichalLytek merged commit 1426446 into MichalLytek:master Dec 22, 2018
@MichalLytek
Copy link
Owner

@kenpusney
Once again: thank you very much for your contribution! 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community 👨‍👧 Something initiated by a community Enhancement 🆕 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants