Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic types support #255

Merged
merged 4 commits into from
Feb 21, 2019
Merged

Generic types support #255

merged 4 commits into from
Feb 21, 2019

Conversation

MichalLytek
Copy link
Owner

@MichalLytek MichalLytek commented Feb 16, 2019 •
edited
Loading

This PR closes #180 🔒

@MichalLytek MichalLytek added the Enhancement 🆕 New feature or request label Feb 16, 2019
@MichalLytek MichalLytek added this to the 1.0.0 release milestone Feb 16, 2019
@MichalLytek MichalLytek self-assigned this Feb 16, 2019
@codecov
Copy link

codecov bot commented Feb 16, 2019 •
edited
Loading

Codecov Report

Merging #255 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
+ Coverage   95.43%   95.56%   +0.12%     
==========================================
  Files          67       67              
  Lines         921      925       +4     
  Branches       69       72       +3     
==========================================
+ Hits          879      884       +5     
+ Misses         40       38       -2     
- Partials        2        3       +1
Impacted Files Coverage Δ
src/decorators/InputType.ts 100% <ø> (ø) ⬆️
src/decorators/ObjectType.ts 100% <ø> (ø) ⬆️
src/decorators/InterfaceType.ts 100% <ø> (ø) ⬆️
src/schema/schema-generator.ts 96.13% <100%> (+0.08%) ⬆️
src/helpers/decorators.ts 92.85% <0%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37d499c...1871aae. Read the comment docs.

@MichalLytek MichalLytek force-pushed the generic-types branch 4 times, most recently from 88476ba to e3ca4e9 Compare February 18, 2019 19:09
@MichalLytek MichalLytek marked this pull request as ready for review February 21, 2019 18:40
@MichalLytek MichalLytek changed the title WIP: Generic types support Generic types support Feb 21, 2019
@MichalLytek MichalLytek merged commit 084ca96 into master Feb 21, 2019
@MichalLytek MichalLytek deleted the generic-types branch February 21, 2019 21:01
@frankdugan3
Copy link

This feature looks awesome! Any chance for a release bump that includes this feature?

@MichalLytek
Copy link
Owner Author

@frankdugan3 See #180 (comment)

This was referenced Feb 23, 2020
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MichalLytek MichalLytek

Labels
Enhancement 🆕 New feature or request
Projects
None yet
Milestone
1.0.0 release
Development

Successfully merging this pull request may close these issues.

Generic types support
2 participants
@MichalLytek @frankdugan3