Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(emit-schema): add support for recursive directory creation #269

Merged
merged 29 commits into from
Mar 11, 2019
Merged

feat(emit-schema): add support for recursive directory creation #269

merged 29 commits into from
Mar 11, 2019

Conversation

mszekiel
Copy link
Contributor

@mszekiel mszekiel commented Mar 3, 2019

@codecov
Copy link

codecov bot commented Mar 3, 2019

Codecov Report

Merging #269 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
+ Coverage   95.52%   95.67%   +0.14%     
==========================================
  Files          66       67       +1     
  Lines         916      947      +31     
  Branches       72       72              
==========================================
+ Hits          875      906      +31     
  Misses         38       38              
  Partials        3        3
Impacted Files Coverage Δ
src/utils/buildSchema.ts 100% <100%> (ø) ⬆️
src/utils/emitSchemaDefinitionFile.ts 100% <100%> (ø) ⬆️
src/helpers/filesystem.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22bb3ef...4ce5c44. Read the comment docs.

tests/functional/emit-schema-sdl.ts Outdated Show resolved Hide resolved
src/utils/emitSchemaDefinitionFile.ts Outdated Show resolved Hide resolved
@MichalLytek MichalLytek added Enhancement 🆕 New feature or request Community 👨‍👧 Something initiated by a community labels Mar 3, 2019
@MichalLytek MichalLytek added this to the 1.0.0 release milestone Mar 3, 2019
@mszekiel
Copy link
Contributor Author

mszekiel commented Mar 3, 2019

After all attempts I'll just remove failing tests. There's no clear reason why it is happening. If someone have idea or can do this please feel free to do this.

More info:
Test is failing if we provide other path than path.resolve one, for eg. string, path.join. On my local machine everything is working and all tests are passing.

@mszekiel
Copy link
Contributor Author

mszekiel commented Mar 4, 2019

Changed custom functions to fs-extra - let's use something well maintained and used.

@MichalLytek
Copy link
Owner

@xanaxx
It's bad that you've decided to go with fs-extra - I can't accept that:
https://packagephobia.now.sh/result?p=fs-extra

@mszekiel
Copy link
Contributor Author

mszekiel commented Mar 4, 2019

@19majkel94
Okay. I'll try to take other attempt on this one. I think I've found problem with last issue which drove me to use fs-extra.

@mszekiel
Copy link
Contributor Author

mszekiel commented Mar 5, 2019

Please check this one. Only using rimraf in tests and as devDependency.

@MichalLytek
Copy link
Owner

@mszekiel
I've refactored the filesystem operation helpers to async/await to simplify them and the mocks in tests.

Please check if everything looks right to you and then we can merge it 😉

@MichalLytek MichalLytek merged commit 6604bdb into MichalLytek:master Mar 11, 2019
@MichalLytek
Copy link
Owner

@mszekiel
Thanks for your contribution! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community 👨‍👧 Something initiated by a community Enhancement 🆕 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants