Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types field at package.json, because we do not use default value #276

Merged
merged 2 commits into from
Mar 16, 2019
Merged

Conversation

galkin
Copy link
Contributor

@galkin galkin commented Mar 12, 2019

@19majkel94, I migrated to 0.17 and lost typescripts support at WebStorm. This pull should fix the issue.

@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #276 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #276   +/-   ##
=======================================
  Coverage   95.67%   95.67%           
=======================================
  Files          67       67           
  Lines         947      947           
  Branches       72       72           
=======================================
  Hits          906      906           
  Misses         38       38           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51278f4...67f938e. Read the comment docs.

@MichalLytek MichalLytek added Bug 🐛 Something isn't working Community 👨‍👧 Something initiated by a community labels Mar 14, 2019
MichalLytek
MichalLytek previously approved these changes Mar 16, 2019
Copy link
Owner

@MichalLytek MichalLytek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💪

@MichalLytek
Copy link
Owner

@galkin
I don't have Webstorm but this change doesn't break VSCode support so we can safely merge it 🎉

@MichalLytek MichalLytek merged commit 572eddd into MichalLytek:master Mar 16, 2019
@ForsakenHarmony
Copy link

ForsakenHarmony commented Mar 27, 2019

should have been broken in vscode as well 🤔

also can you please release this, it's pretty important for a typescript focused package

@galkin
Copy link
Contributor Author

galkin commented Mar 28, 2019

@19majkel94, when will you publish new version?

@MichalLytek
Copy link
Owner

@ForsakenHarmony @galkin
It took me a while but [email protected] has been released! 🎉

@galkin
Copy link
Contributor Author

galkin commented Mar 29, 2019

@19majkel94, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 Something isn't working Community 👨‍👧 Something initiated by a community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants