Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(interfaces-unions): handle resolveType returning undefined #731

Merged
merged 1 commit into from
Oct 18, 2020
Merged

fix(interfaces-unions): handle resolveType returning undefined #731

merged 1 commit into from
Oct 18, 2020

Conversation

MichalLytek
Copy link
Owner

Closes #728

@MichalLytek MichalLytek added the Bugfix 🐛 🔨 PR that fixes a known bug label Oct 17, 2020
@MichalLytek MichalLytek self-assigned this Oct 17, 2020
@codecov
Copy link

codecov bot commented Oct 17, 2020 •
edited
Loading

Codecov Report

Merging #731 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #731   +/-   ##
=======================================
  Coverage   95.39%   95.39%           
=======================================
  Files          80       80           
  Lines        1478     1478           
  Branches      292      293    +1     
=======================================
  Hits         1410     1410           
  Misses         65       65           
  Partials        3        3
Impacted Files Coverage Δ
src/schema/schema-generator.ts 98.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd90856...30752df. Read the comment docs.

@MichalLytek MichalLytek merged commit 5a7579e into master Oct 18, 2020
@MichalLytek MichalLytek deleted the fix-resolve-type branch October 18, 2020 15:23
@MichalLytek MichalLytek added this to the 1.x versions milestone Oct 18, 2020
@MichalLytek MichalLytek mentioned this pull request Mar 22, 2021
Closed
@MichalLytek MichalLytek modified the milestones: 1.x versions, 1.2 Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MichalLytek MichalLytek

Labels
Bugfix 🐛 🔨 PR that fixes a known bug
Projects
None yet
Milestone
2.0 release
Development

Successfully merging this pull request may close these issues.

How to make @Query when create a schema having refPath field with createUnionType?
1 participant
@MichalLytek