Proposed protocol addition "step-into-specifc" #39

[weinand]

Protocol addition "step-into-specifc" (#39) contains:

• a new optional supportsStepInTargetsRequest capability
• a new type StepInTarget
• a new optional stepInTargets request
• a new optional argument targetId on the stepIn request

[DavidKarlas]

I'm just thinking if StepInTargetsArguments should have just threadId: number;...

Since providing source location, line and column might not be that simple from editor/ide side to calculate for different languages...
To me it seems it would be nicer if debug agent could figure that out based on thread Id what options are available...
I guess editor/ide could just send Source, Line and Column where that thread has stopped...

I would prefer to see what someone from VS team thinks of this, since I'm not very familiar with this feature(XS team don't have this, yet), so I'm not sure if threadId: number; would be enough...

Btw... I'm not fan of number | string because some languages might have problems handling that...

[gregg-miskelly]

For VS, we don't need a source location, but we would need to know the thread id.

[jacdavis]

I think the frameid would actually be best in this case.

[gregg-miskelly]

Are frame ids required to be unique across threads? Since we always step the leaf-most frame, I was thinking that merely knowing the thread should be enough.

[jacdavis]

That’s probably true for the vs debugger scenario, but it seems a bit more flexible to not bake that assumption into the protocol. Perhaps a threadid / frameid pair would be best?

From: Gregg Miskelly [mailto:[email protected]]
Sent: Monday, July 18, 2016 9:44 AM
To: Microsoft/vscode-debugadapter-node [email protected]
Cc: Jackson Davis [email protected]; Comment [email protected]
Subject: Re: [Microsoft/vscode-debugadapter-node] Proposed protocol addition "step-into-specifc" #39 (#44)

Are frame ids required to be unique across threads? Since we always step the leaf-most frame, I was thinking that merely knowing the thread should be enough.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://pull/44#issuecomment-233386089, or mute the threadhttps:/notifications/unsubscribe-auth/AM3W_RsUwuokCQ_B0dA_JZtAf35lo63jks5qW61egaJpZM4JMm7a.

[weinand]

Ok, let's go with the frameId instead of src / line / column for the StepInTargetsRequest. Frame ids must be unique across threads and the protocol already uses frame ids with that assumption (that is without a accompanying threadId).
In addition I've changed the type of the StepInTarget id to number.