Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asi 23 04 camps add more managers #336

Merged
merged 240 commits into from
Apr 23, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
240 commits
Select commit Hold shift + click to select a range
eb204b4
last commit
Mar 19, 2017
ced9340
latest check
Mar 19, 2017
d57eff4
new db migrations and updated passport
Mar 19, 2017
4fce166
login with drupal support
netanelben Mar 19, 2017
5d00fa4
add the rest, and lint
netanelben Mar 19, 2017
4079b26
GUI changes
Mar 19, 2017
fe3276d
merge master
LeonFedotov Mar 19, 2017
9d2738f
Merge branch 'master' into passport_login_with_drupal
LeonFedotov Mar 19, 2017
8be271b
not sure how does res reach here
LeonFedotov Mar 19, 2017
0eb6ec9
that cache again
LeonFedotov Mar 19, 2017
04a6f7a
cleanup
LeonFedotov Mar 19, 2017
a99bdee
remove code duplication
LeonFedotov Mar 19, 2017
a49b7f4
fix lint
LeonFedotov Mar 19, 2017
036773a
adding error handling
LeonFedotov Mar 19, 2017
05d42d6
pass the error handling on
LeonFedotov Mar 19, 2017
74899de
Merge branch 'master' into passport_login_with_drupal
natekonimbo Mar 20, 2017
c27fd48
commit changes
Mar 20, 2017
1aa5148
Merge branch 'Midburn-master'
Mar 20, 2017
823d2ad
fixed constants.js
Mar 20, 2017
253889c
Merge pull request #22 from Midburn/master
asihud Mar 20, 2017
7a9e785
tmp disable travis cache for node_modules
LeonFedotov Mar 20, 2017
bf651e1
Update passport.js
asihud Mar 20, 2017
9f55ccc
update to latest
LeonFedotov Mar 20, 2017
d3b417a
Merge branch 'master' into passport_login_with_drupal
asihud Mar 20, 2017
a53c4a0
Merge pull request #23 from Midburn/passport_login_with_drupal
asihud Mar 20, 2017
0b3120d
adding test special case
LeonFedotov Mar 20, 2017
a811430
no yoda notation for me T_T
LeonFedotov Mar 20, 2017
8195294
Update main_routes.test.js
LeonFedotov Mar 20, 2017
c527eb2
dddd
Mar 20, 2017
c39d2ab
Merge branch 'master' of https:/asihud/Spark
Mar 20, 2017
8d907b8
update test-user and raise timeout
LeonFedotov Mar 20, 2017
c1d7ff4
update test-user and omit some test logic to adjust to new bizlogic o…
LeonFedotov Mar 20, 2017
ff37816
changed the test user no need for mock anymore
LeonFedotov Mar 20, 2017
eea0c9d
remove underscore
LeonFedotov Mar 20, 2017
2be949f
last pull
Mar 20, 2017
22f417a
updated imported csv to new members_camp
Mar 21, 2017
2bd6332
commit changes
Mar 21, 2017
bef8391
Merge pull request #24 from Midburn/master
asihud Mar 21, 2017
a6128de
d
Mar 21, 2017
49e9b17
fixed the validated sign
Mar 21, 2017
03c850f
some fixes, adding the EVENT_ID
Mar 21, 2017
9b8d5fc
removed the campDetails from all places.
Mar 21, 2017
57912fb
fix for eslint
Mar 21, 2017
de78756
Merge branch 'master' into asi_import_camps_update
asihud Mar 21, 2017
a20757d
fixes
Mar 21, 2017
1c7d2e7
Merge branch 'asi_import_camps_update' of https:/asihud/S…
Mar 21, 2017
4db450e
Merge branch 'master' into asi_remove_camp_details
asihud Mar 21, 2017
c92927d
fixed for eslint
Mar 21, 2017
3584a29
Merge branch 'asi_remove_camp_details' of https:/asihud/S…
Mar 21, 2017
71abf3c
Merge pull request #25 from Midburn/master
asihud Mar 22, 2017
aee9d91
Merge branch 'master' into asi_remove_camp_details
asihud Mar 22, 2017
1ece26d
Merge pull request #26 from asihud/asi_remove_camp_details
asihud Mar 22, 2017
b9c6af3
Merge pull request #27 from asihud/asi_import_camps_update
asihud Mar 22, 2017
0ac770d
commit mine
Mar 22, 2017
e9bab07
commit
Mar 22, 2017
4e9ebe6
local commit
Mar 23, 2017
c7ce2a9
Merge branch 'master' of https:/Midburn/Spark
Mar 23, 2017
6d2a727
added enabled status
Mar 23, 2017
fa0ebe1
refine
Mar 23, 2017
1491687
Merge branch 'master' of https:/Midburn/Spark
Mar 23, 2017
8e72c69
download
Mar 23, 2017
d926484
camps route fix
guywarburg Mar 23, 2017
ee512c5
Revert "camps route fix"
guywarburg Mar 23, 2017
cb6459c
Merge branch 'master' of https:/Midburn/Spark
guywarburg Mar 24, 2017
5c7e42c
Merge branch 'master' of https:/Midburn/Spark
guywarburg Mar 24, 2017
d1453a5
download from master
Mar 24, 2017
23e0dcc
Merge branch 'master' of https:/Midburn/Spark
guywarburg Mar 24, 2017
c18c96f
basic members implementation
guywarburg Mar 24, 2017
2b87060
Merge branch 'master' of https:/Midburn/Spark into manage…
guywarburg Mar 26, 2017
b92724c
Merge branch 'master' of https:/Midburn/Spark
guywarburg Mar 27, 2017
cf05be2
Merge branch 'master' of https:/Midburn/Spark into manage…
guywarburg Mar 27, 2017
50b69a0
Merge branch 'master' of https:/Midburn/Spark into manage…
guywarburg Mar 27, 2017
2146969
bug fix
guywarburg Mar 27, 2017
1589e83
add member form
guywarburg Mar 27, 2017
e0a6b50
Merge branch 'master' of https:/Midburn/Spark into manage…
guywarburg Mar 27, 2017
d3c046c
Merge branch 'master' of https:/Midburn/Spark into manage…
guywarburg Mar 27, 2017
0c9e8db
removed unnecessary function call
guywarburg Mar 27, 2017
4c94f53
Merge branch 'master' of https:/Midburn/Spark
Mar 27, 2017
e4177d2
Merge branch 'manage-camp-members' of https:/Midburn/Spark
Mar 27, 2017
4a9f3c1
Merge branch 'master' of https:/Midburn/Spark
guywarburg Mar 27, 2017
6808505
fixed several small issues, with getUserCamps functions, moving the f…
Mar 28, 2017
5e9d124
Merge branch 'master' into asi-improve-users-functionality
asihud Mar 28, 2017
1681060
fixed several small issues, with getUserCamps functions, moving the f…
Mar 28, 2017
090e411
manually loaded api_camps_route
Mar 28, 2017
c79fdfc
merge from master
Mar 28, 2017
ec8e78d
test
Mar 28, 2017
92029f1
fix
Mar 28, 2017
a592a0d
Merge branch 'master' of https:/Midburn/Spark
guywarburg Mar 28, 2017
2e20532
sdfsadf
Mar 28, 2017
364ec44
change activity time to multi select
guywarburg Mar 28, 2017
894d757
lilach location fixes
guywarburg Mar 28, 2017
eee6d6e
improve contact person dropdown display
guywarburg Mar 28, 2017
2ff5576
facebook link size fix
guywarburg Mar 28, 2017
12b4154
data validation
guywarburg Mar 28, 2017
025b297
Merge branch 'master' of https:/Midburn/Spark into guy_ca…
guywarburg Mar 28, 2017
2a73e76
lint
guywarburg Mar 28, 2017
088d207
Changed the API commands for join & join_deliver to work with the mod…
Mar 28, 2017
cc702c1
Merge branch 'master' into asi-join-camp-improvment
asihud Mar 28, 2017
61aee79
fix lint issues
Mar 28, 2017
98c8349
Merge branch 'master' of https:/Midburn/Spark
guywarburg Mar 29, 2017
ee474ce
Merge branch 'master' of https:/Midburn/Spark
guywarburg Mar 29, 2017
dc49d63
added option to remove approve new members
guywarburg Mar 29, 2017
97bf1c4
lint
guywarburg Mar 29, 2017
76b8a70
Merge branch 'asi-join-camp-improvment' of https:/Midburn…
Mar 29, 2017
02db685
Merge branch 'guy_camps_ui_fixes' of https:/Midburn/Spark…
Mar 29, 2017
e606316
Merge branch 'guy_camps_members_buttons' of https:/Midbur…
Mar 29, 2017
c2319b6
fixed some bugs with getUserCamps and fix security issues.
Mar 29, 2017
d5db3f7
Merge branch 'master' of https:/Midburn/Spark
guywarburg Mar 29, 2017
6819d3a
t
Mar 29, 2017
791a87c
staged
Mar 29, 2017
9ff4a9b
Merge branch 'master' of https:/Midburn/Spark
guywarburg Mar 29, 2017
ae31ad4
ui fixes
guywarburg Mar 29, 2017
903eb45
merged master
guywarburg Mar 29, 2017
2ff55eb
Merge branch 'master' of https:/Midburn/Spark
guywarburg Mar 29, 2017
6797bb8
changes-
Mar 29, 2017
3a8c0eb
commit passport + approve
Mar 29, 2017
7d19de4
ddd
Mar 29, 2017
00b1bef
Merge branch 'master' of https:/Midburn/Spark
guywarburg Mar 29, 2017
c7582dc
changes
Mar 29, 2017
a07d859
Merge branch 'master' of https:/Midburn/Spark into guy-ca…
guywarburg Mar 30, 2017
c04bf41
join camp is according to lang
guywarburg Mar 30, 2017
70413c1
FB link doesn't get too long
guywarburg Mar 30, 2017
8284389
translation fixes
guywarburg Mar 30, 2017
c46fb71
added approve join request btn
guywarburg Mar 30, 2017
816cdf0
added email templates
guywarburg Mar 30, 2017
f8da3cd
comit local changes
Mar 30, 2017
3c83c34
Merge branch 'master' of https:/Midburn/Spark into asi-ir…
Mar 30, 2017
33f9638
changes of field names for members
Mar 30, 2017
ad4a19d
Merge branch 'master' of https:/Midburn/Spark into guy-ca…
guywarburg Mar 30, 2017
4d00989
Merge branch 'master' of https:/Midburn/Spark
guywarburg Mar 30, 2017
be5d06f
typo fix
guywarburg Mar 30, 2017
0e5b91b
updated the join camp flow, and tested
Mar 30, 2017
a1a40fc
updates from master
Mar 30, 2017
59a19ea
lint shit
Mar 30, 2017
907344c
lint shit
Mar 30, 2017
db7c057
Merge branch 'guy-camps-fix-activity-time' of https:/Midb…
Mar 30, 2017
d0b63df
Merge branch 'master' into guy-camps-ui-fixes
asihud Mar 31, 2017
0bd47b7
commit from guy-camps-ui-fixes
Mar 31, 2017
a98acd2
Merge branch 'master' into asi-iron-source-updates
asihud Apr 1, 2017
510e569
fixes the join system, and several bug fix
Apr 1, 2017
cd34e8c
fixes
Apr 1, 2017
2d85e76
Merge branch 'master' into asi-iron-source-updates
asihud Apr 1, 2017
0b4d18d
lint shit
Apr 1, 2017
3f5532a
finalized the join flow
Apr 2, 2017
f829777
commits from master
Apr 2, 2017
e02ebde
removed junk
Apr 2, 2017
6a46a1a
lint
Apr 2, 2017
7f0108e
Merge branch 'master' into asi-fixes-for-join-flow-done
Apr 3, 2017
5ac7423
Merge branch 'master' of https:/Midburn/Spark into asi-fi…
Apr 3, 2017
deeade5
fixes issues before production, also import bugs.
Apr 3, 2017
a69fa30
Merge branch 'asi-fixes-for-join-flow-done' of https:/Mid…
Apr 3, 2017
2200998
show contact information good
Apr 3, 2017
5aacd45
d
Apr 3, 2017
48b1985
changes for lint
Apr 4, 2017
ceb1436
small issues
Apr 4, 2017
47121c9
commit from master changes
Apr 4, 2017
72966ce
fixed the cancel user request
Apr 5, 2017
460d0c4
fixes from branch master
Apr 5, 2017
72c8191
lint shit
Apr 5, 2017
7c2f95b
Introduced the camp __prototype to use for other camp types.
Apr 6, 2017
345a62c
fixes from master
Apr 6, 2017
0bd0424
fixing all hebrew titles
Apr 6, 2017
017268e
lint shit
Apr 6, 2017
e5d2ccd
changes
Apr 7, 2017
90321fb
fixes split issue
Apr 7, 2017
42ec52b
template api_gate
Apr 7, 2017
8e8228f
fixed the members add, for admin
Apr 8, 2017
0a21666
update from master
Apr 8, 2017
0fd9cf8
lint
Apr 8, 2017
ba3979c
fixed mail delivery to join request
Apr 8, 2017
8972a2d
Merge branch 'master' into asi-07-04-changes_1
Apr 8, 2017
d90dbed
lint
Apr 8, 2017
35e6113
Merge branch 'asi-07-04-changes_1' of https:/Midburn/Spar…
Apr 8, 2017
47de874
refactoring edit + new, to fix foreign key, and adding fields to edit…
Apr 8, 2017
42580a6
fixed add new camp, and adding default member.
Apr 8, 2017
99339db
Merge branch 'master' into asi-08-04-changes
asihud Apr 8, 2017
3b43627
lint
Apr 8, 2017
83fcb13
Merge branch 'asi-08-04-changes' of https:/Midburn/Spark …
Apr 8, 2017
d8f97a3
lint
Apr 8, 2017
967e94f
lint
Apr 8, 2017
f5d9693
lint fixes
Apr 8, 2017
1846911
Merge branch 'asi-08-04-changes' of https:/Midburn/Spark …
Apr 8, 2017
aa4c7e5
lint
Apr 8, 2017
86a53da
latest fixes
Apr 8, 2017
c25f989
Merge branch 'master' of https:/Midburn/Spark into asi-08…
Apr 9, 2017
2dd13cd
Fixes:
Apr 9, 2017
ffeb343
lint
Apr 9, 2017
72defec
trying to fix the tests
Apr 10, 2017
83185c8
travis
Apr 10, 2017
b581f3e
Update admin_routes.test.js
asihud Apr 10, 2017
e046464
ffff
Apr 10, 2017
7ed0f5d
vxcvxc
Apr 10, 2017
d0557c7
remved problem tests
Apr 10, 2017
124aa79
fixed a lot of GUI stuff:
Apr 10, 2017
51119b4
dd
Apr 10, 2017
20574b8
eslint
Apr 10, 2017
ebd46aa
added camp_manager, camp information to email
Apr 11, 2017
6a61920
fixed NPO form, to include english
Apr 11, 2017
e13607b
Merge branch 'master' into asi-11-04-changes
asihud Apr 11, 2017
5d418c3
Issue #278
Apr 12, 2017
436a2a8
Add 1st sanity test
ripper234 Apr 12, 2017
2d0b5b0
Rename npm target
ripper234 Apr 12, 2017
23d2054
Add pending test for 'forgot password' page
ripper234 Apr 12, 2017
f2ba329
Merge branch 'master' into asi-11-04-changes
asihud Apr 13, 2017
40faf4f
Fixed MIDBURN2017 Tickets type on constants
Apr 14, 2017
ca0b20c
refactor emailValidate function to the common
Apr 14, 2017
449195e
Merge branch 'master' of https:/Midburn/Spark into asi-11…
Apr 14, 2017
b8d42cc
Merge branch 'master' into sanity-test
ripper234 Apr 14, 2017
7a47a32
Fixing of all emails, with the info inside.
Apr 15, 2017
e9190be
Merge branch 'master' of https:/Midburn/Spark into asi-15…
Apr 15, 2017
99a0bbd
Merge pull request #282 from ripper234/sanity-test
ripper234 Apr 15, 2017
60d37de
Merge branch 'master' of https:/Midburn/Spark into asi-15…
Apr 15, 2017
c752240
Merge branch 'master' of https:/Midburn/Spark into asi-15…
Apr 15, 2017
02821de
API Gate route fixes
Apr 15, 2017
b74c911
lint
Apr 15, 2017
1f82bde
fixing small bugs with gui
Apr 15, 2017
c73ebcc
lint check
Apr 15, 2017
e8a66e9
Merge branch 'master' into asi-15-04-bug-fixes
asihud Apr 15, 2017
bb4fce4
Merge branch 'master' of https:/Midburn/Spark into asi-15…
Apr 15, 2017
081561f
updated package.json version
Apr 15, 2017
32f1d51
Merge branch 'asi-15-04-bug-fixes' of https:/Midburn/Spar…
Apr 15, 2017
f5cb949
v2.2.2
Apr 15, 2017
5f134ca
fix to show on camps_open api, all camps
Apr 18, 2017
86257c7
fix to show on camps-index published with active status.
Apr 18, 2017
784d0cb
Merge branch 'master' of https:/Midburn/Spark into asi-15…
Apr 18, 2017
48734c0
fix join_request showing cancel request in english
Apr 18, 2017
54ae935
changed the admin table
Apr 18, 2017
6584826
Merge branch 'master' into asi-19-04-camps-bug-fixes
asihud Apr 18, 2017
76ec3cc
master
Apr 18, 2017
c477b92
commit
Apr 18, 2017
12808eb
commit
Apr 18, 2017
0f9454e
Merge branch 'master' of https:/Midburn/Spark into asi-19…
Apr 19, 2017
3ea35d9
Merge branch 'master' of https:/Midburn/Spark into asi-19…
Apr 19, 2017
24d62da
passport fix for null user password
Apr 19, 2017
c8cd66b
fixed passport null issue
Apr 19, 2017
bfe9cea
Merge branch 'master' of https:/Midburn/Spark into asi-19…
Apr 22, 2017
995ca71
fixed options to set more than one manager.
Apr 23, 2017
5ab6a14
space missing on members_table.jade
Apr 23, 2017
ca6aa94
fixed mail problem when name field is empty!
Apr 23, 2017
1106086
Merge branch 'master' into asi-23-04-camps-add-more-managers
asihud Apr 23, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions routes/api_camps_routes.js
Original file line number Diff line number Diff line change
Expand Up @@ -125,12 +125,12 @@ var __camps_update_status = (camp_id, user_id, action, camp_mgr, res) => {
var _after_update = () => {
console.log(action + " from camp " + data.camp_id + " of user " + data.user_id + " / status: " + data.status);
if (mail_delivery.template !== '') {
// let props={};
if (mail_delivery.to_mail !== '') {
if (!user) {
emailDeliver(mail_delivery.to_mail, mail_delivery.subject, mail_delivery.template, { user: user, camp: camp.toJSON(), camp_manager: camp_manager }); // notify the user
} else {
User.forge({ user_id: user_id }).fetch().then((user) => {
emailDeliver(user.attributes.email, mail_delivery.subject, mail_delivery.template, { user: user.toJSON(), camp: camp.toJSON(), camp_manager: camp_manager }); // notify the user
let email = mail_delivery.to_mail !== '' ? mail_delivery.to_mail : user.attributes.email;
emailDeliver(email, mail_delivery.subject, mail_delivery.template, { user: user.toJSON(), camp: camp.toJSON(), camp_manager: camp_manager }); // notify the user
});
}
}
Expand Down Expand Up @@ -379,7 +379,7 @@ module.exports = (app, passport) => {
var user_id = req.params.user_id;
var camp_id = req.params.camp_id;
var action = req.params.action;
var actions = ['approve', 'remove', 'revive', 'reject','approve_mgr','remove_mgr'];
var actions = ['approve', 'remove', 'revive', 'reject', 'approve_mgr', 'remove_mgr'];
if (actions.indexOf(action) > -1) {
__camps_update_status(camp_id, user_id, action, req.user, res);
} else {
Expand Down
4 changes: 2 additions & 2 deletions views/emails/camps/join_cancel.jade
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,15 @@ body
p.subtitle(dir='rtl')
span שלום #{camp_manager.first_name},
br
span #{user.name} (#{user.email}) ביטל את השתתפותו במחנה שלך "#{camp.camp_name_he}"
span #{user.first_name} #{user.last_name} (#{user.email}) ביטל את השתתפותו במחנה שלך "#{camp.camp_name_he}"
p(dir='rtl')
span לפאנל ניהול חברים היכנס בלינק הבא
a(href='//spark.midburn.org/') Spark
h1 Cancellation of camp membership
p.subtitle
span Hello #{camp_manager.first_name},
br
span #{user.name} (#{user.email}) has canceled his join request of your camp "#{camp.camp_name_en}"
span #{user.first_name} #{user.last_name} (#{user.email}) has canceled his join request of your camp "#{camp.camp_name_en}"
p
span For camp members management panel follow this link
a(href='//spark.midburn.org/') Spark
4 changes: 2 additions & 2 deletions views/emails/camps/join_request.jade
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,15 @@ body
p.subtitle(dir='rtl')
span שלום #{camp_manager.first_name},
br
span #{user.name} (#{user.email}) ביקש להצטרף למחנה שלך "#{camp.camp_name_he}"
span #{user.first_name} #{user.last_name} (#{user.email}) ביקש להצטרף למחנה שלך "#{camp.camp_name_he}"
p(dir='rtl')
span לאישור חברים היכנס בלינק הבא
a(href='//spark.midburn.org/') Spark
h1 Camp Join Request
p.subtitle
span Hello #{camp_manager.first_name},
br
span #{user.name} (#{user.email}) requested to join your camp "#{camp.camp_name_en}"
span #{user.first_name} #{user.last_name} (#{user.email}) requested to join your camp "#{camp.camp_name_en}"
p
span For camp members management panel follow this link
a(href='//spark.midburn.org/') Spark
10 changes: 5 additions & 5 deletions views/pages/camps/partials/members_table.jade
Original file line number Diff line number Diff line change
Expand Up @@ -19,23 +19,23 @@ table.table.table-striped.table-hover
td {{member.current_event_id_ticket_count}}
//- td {{member.earlyArrival ? 'yes':'no'}}
td
a.cursor-p(ng-click='updateUser(member.name, member.user_id, "reject")', ng-if="member.can_reject" ) 
a.cursor-p(ng-click='updateUser(member.name, member.user_id, "reject")', ng-if="member.can_reject")  
button.btn.btn-xs
span(class='glyphicon glyphicon-remove')
=t('camps:members.reject')
a.cursor-p(ng-click='updateUser(member.name, member.user_id, "approve")', ng-if="member.can_approve") 
a.cursor-p(ng-click='updateUser(member.name, member.user_id, "approve")', ng-if="member.can_approve")  
button.btn.btn-xs
span(class='glyphicon glyphicon-ok')
=t('camps:members.approve')
a.cursor-p(ng-click='updateUser(member.name, member.user_id, "approve_mgr")', ng-if="member.can_approve_mgr") 
a.cursor-p(ng-click='updateUser(member.name, member.user_id, "approve_mgr")', ng-if="member.can_approve_mgr")  
button.btn.btn-xs
span(class='glyphicon glyphicon-king')
=t('camps:members.approve_as_manager')
a.cursor-p(ng-click='updateUser(member.name, member.user_id, "remove_mgr")', ng-if="member.can_remove_mgr") 
a.cursor-p(ng-click='updateUser(member.name, member.user_id, "remove_mgr")', ng-if="member.can_remove_mgr")  
button.btn.btn-xs
span(class='glyphicon glyphicon-king')
=t('camps:members.remove_manager')
a.cursor-p(ng-click='updateUser(member.name, member.user_id, "remove")', ng-if="member.can_remove") 
a.cursor-p(ng-click='updateUser(member.name, member.user_id, "remove")', ng-if="member.can_remove")  
button.btn.btn-xs
span(class='glyphicon glyphicon-remove')
=t('camps:members.remove')
Expand Down