Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] midburn session #341

Closed
wants to merge 23 commits into from
Closed

[WIP] midburn session #341

wants to merge 23 commits into from

Conversation

noam-almog
Copy link
Contributor

@noam-almog noam-almog commented Apr 24, 2017

Encode/Decode midburn session

  • read data from drupal including roles
  • encrypt/decrypt jwt token from http only cookie

todo: need to replace hardcoded keys with proper RSA keys.

waiting to be integrated

@noam-almog noam-almog changed the title [WIP] midburn session [WIP] midburn session - waiting for integration Apr 26, 2017
@noam-almog noam-almog changed the title [WIP] midburn session - waiting for integration [WIP] midburn session May 2, 2017
@roy-zahor
Copy link
Contributor

roy-zahor commented May 3, 2017

@noam-almog It is a bit hard to review because many files have changed, and a lot of code got commented.
In general:

  1. I do like the code organization and abstraction.
  2. Did you removed the drupal_login logic? I didn't find it anymore and we should keep it.

@noam-almog
Copy link
Contributor Author

@roy-zahor re-added the drupal flow after getting some feedback from @LeonFedotov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants