Volunteers system integration #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@noam-almog @may-ben-arie Please take a look |
noam-almog
reviewed
Apr 27, 2017
routes/volunteering_routes.js
Outdated
| User.forge({user_id: req.user.attributes.user_id}).fetch().then(user => { | ||
| if (user) { | ||
| var token = passportLib.generateJwtToken(user.attributes.email); | ||
| res.redirect("http://URL.OF.VOLUNTEERING.SYSTEM.LANDING.PAGE?auth_token=" + token); |
There was a problem hiding this comment.
@roy-zahor why are we back to the solution where we send the token as a parameter ?
i thought we agreed on transferring it as a cookie
There was a problem hiding this comment.
@noam-almog You are correct, I didn't describe this PR correctly. What I was trying to show is how relatively easy is to use existing libraries to implement the SSO. I didn't mean to use token as a parameter.
There was a problem hiding this comment.
@roy-zahor my file changes are almost done i'll keep you guys informed
There was a problem hiding this comment.
@noam-almog Cool! Closing this issue..
noam-almog
force-pushed
the
volunteers_sso
branch
from
afa37b9
to
33728b8
Compare
roy-zahor
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set env variable for volunteers base url
VOLUNTEERS_BASE_URL