Added support for running tests on Travis-CI #8
Conversation
|
follow-up issue: #9 |
OriHoch
changed the title
OriHoch
changed the title
minor fixes to create camp and to dev/debug
|
great contribution, CI is needed from day-1. |
Camps module
Added support for translations namespace
…be-more-friendly update documentation to be more user friendly
…tions moved sensitive configurations to opsworks.js
|
This should hopefully work with our docker image. Once we have a staging server with a working docker image this should be tested against it and merged. |
…tion fix recaptcha api localization param according to language
There was a problem hiding this comment.
ACK, Great work.
-
Knex should be used for migrations instead of plain SQL as per standardize the migration and DB setup process #4. (current .sh calls them). The
/sqlfolder is deleted in another standardize the db migration process (switch to knex) and use sqlite for dev environment #18 I believe, let's update this PR to reflect that. -
Please no .sh files, I think it's better to put the logic there into the package.json file directly (let's use that as a build system). See Introduction to Using NPM as a Build Tool.
(Item 2 above is not a blocker, I ACK this PR, if you don't do Item 2 please copy-paste the text above into a new issue)
…sqlite-for-local-development # Conflicts: # README.md # config/default.js # opsworks.js # sql/camps.sql # sql/schema.sql
…om:OriHoch/Spark into 17-should-use-sqlite-for-local-development
…ocal-development standardize the db migration process (switch to knex) and use sqlite for dev environment
|
thanks @ripper234 - I will update according to your comments and merge |
|
There are some conflicts, I'll open a new PR |
Travis-CI is free for open source projects
https://travis-ci.org/OriHoch/Spark/builds/190556286
tests are failing but not because of Travis-CI..