Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block production race condition in integration test #10009

Conversation

mrmr1993
Copy link
Member

This PR tweaks the behaviour of the block producer to check that the best tip isn't at the slot that its currently trying to produce at.

This race condition shouldn't happen in practice on a full network, but arises in some of the snarkless integration tests in #10005 due to the change in timings of the new poseidon hash function for kimchi.

Checklist:

  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Jan 12, 2022
@mrmr1993 mrmr1993 requested a review from a team as a code owner January 12, 2022 19:10
@mrmr1993 mrmr1993 merged commit de79972 into compatible Jan 12, 2022
@mrmr1993 mrmr1993 deleted the feature/choose-parent-breadcrumb-when-already-produced-for-slot branch January 12, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants