Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert breaking change to versioned type #10018

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

mrmr1993
Copy link
Member

No description provided.

@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Jan 13, 2022
@mrmr1993 mrmr1993 requested a review from a team as a code owner January 13, 2022 14:48
Copy link
Member

@nholland94 nholland94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I think this will work as a way to avoid the breaking type change. Thanks for doing this @mrmr1993! And sorry for all the trouble, I should have known better, but also don't know why CI let me merge this anyway.

@mrmr1993 mrmr1993 merged commit 453b453 into compatible Jan 13, 2022
@mrmr1993 mrmr1993 deleted the feature/revert-type-changes branch January 13, 2022 15:29
psteckler added a commit that referenced this pull request Jan 14, 2022
…pe-changes"

This reverts commit 453b453, reversing
changes made to 3cfa483.
lk86 added a commit that referenced this pull request Jan 24, 2022
…pe-changes"

This reverts commit 453b453, reversing
changes made to 3cfa483.
QuiteStochastic pushed a commit that referenced this pull request Feb 1, 2022
…pe-changes"

This reverts commit 453b453, reversing
changes made to 3cfa483.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants