Remove unconfigurable_constants module #16196
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martyall
changed the base branch from
develop
to
martin/create-constants-loader-part-1
|
!ci-nightly-me |
georgeee
approved these changes
Oct 9, 2024
| Logger.make_itn_logger_config | ||
| ~rpc_handshake_timeout:compile_config.rpc_handshake_timeout | ||
| ~rpc_heartbeat_timeout: | ||
| ( compile_config.rpc_heartbeat_timeout |> Time.Span.to_sec |
There was a problem hiding this comment.
This seems to be a repeated pattern. What if we make rpc_heartbeat_timeout of compile config a TIme_ns.Span.t?
|
|
||
| let zkapp_cmd_limit_hardcap = 128 | ||
|
|
||
| (* These are fine to be non-configurable *) |
There was a problem hiding this comment.
Suggested change
| (* These are fine to be non-configurable *) |
src/app/cli/src/init/client.ml
Outdated
| (Args.zip5 config_file payment_path_flag proof_path_flag address_flag | ||
| token_flag ) | ||
| ~f:(fun port (config_file, payment_path, proof_path, pk, token_id) -> | ||
| let%bind compile_config = |
There was a problem hiding this comment.
Code below is repeated more than ten times, probably we could remove the duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #16186
Fixes #16107
The problem
We have this
mina_node_config.unconfigurable_constantspackage that is leaking out the usage ofmina_node_config. We need to access these fields via the standard*_constantsrecords.Solution
mina_node_config.unconfigurable_constantsNode_configvalues in the codebase outside ofsignature_kind,genesis_constantsandmina_compile_configmodulesunconfigurable_constantswere duplicated in bothMina_compile_configandGenesis_constants. It seems more natural to keep them in one place andGenesis_constantsis the obvious choice. Remove the duplicated fields.