Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update proof systems commit to include safe lagrange basis #16207

Open
wants to merge 3 commits into
base: compatible
Choose a base branch
from

Conversation

45930
Copy link

@45930 45930 commented Oct 10, 2024

Explain your changes:

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@45930 45930 requested a review from a team as a code owner October 10, 2024 13:45
@volhovm
Copy link
Member

volhovm commented Oct 10, 2024

!ci-build-me

@volhovm volhovm self-requested a review October 10, 2024 14:35
@volhovm
Copy link
Member

volhovm commented Oct 10, 2024

@45930 you'll have to update the bindings (src/lib/crypto/kimchi_bindings/stubs and probably also ..../wasm), since the underlying proof-systems commit changes the SRS access interface.

@45930
Copy link
Author

45930 commented Oct 10, 2024

!ci-build-me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants