Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.17 mappings #94

Open
TobiasDeBruijn opened this issue Jun 11, 2021 · 5 comments
Open

Add 1.17 mappings #94

TobiasDeBruijn opened this issue Jun 11, 2021 · 5 comments

Comments

@TobiasDeBruijn
Copy link

Hey there,

When opening the Mojang->Spigot mappings for 1.17, Error while loading spigot mappings: Version not found is thrown.

However content is displayed, but I don't know how up-to-date this is, or if it is correct. The 'Spigot Name' field is empty.

@TobiasDeBruijn
Copy link
Author

Note also that some classes, e.g net.minecraft.network.protocol.game.PacketPlayOutPosition don't show up in search results.

@MiniDigger
Copy link
Owner

there is way more stuff to do, as spigot partly uses mojang mappings now.

and since paper will be moving to mojang mappings, quite frankly, am not sure if updating it is worth it, everbody should code against mojang mappings.

ill still leave this open just in case

@TobiasDeBruijn
Copy link
Author

I suppose it might be best to leave the spigot names empty, since as you mentioned people should now be using mojang mappings.

However, I do think it's important to update the mappings, even just to get the mappings between mojang (sensible) names and their obfuscated counterparts, it's darn useful information for people (like me) using reflection :D

@andrew121410
Copy link

I'm not sure on how to make a pull request for glist's aka(builddata.json) also this might not be correct I think it is though

https://hub.spigotmc.org/stash/projects/SPIGOT/repos/builddata/raw/mappings/bukkit-1.17-cl.csrg?at=b6171b29323150f031a1a22e0f42c18809878ef1

https://hub.spigotmc.org/stash/projects/SPIGOT/repos/builddata/raw/mappings/bukkit-1.17-members.csrg?at=b6171b29323150f031a1a22e0f42c18809878ef1

@MiniDigger
Copy link
Owner

changing the gist is not enough, the code itself needs to be fixed. 1.16.5 is already broken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants