Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comment lines about the default mount propagation #159

Merged
merged 1 commit into from
Feb 11, 2023
Merged

Fix comment lines about the default mount propagation #159

merged 1 commit into from
Feb 11, 2023

Commits on Feb 11, 2023

  1. Fix comment lines about the default mount propagation 

    dockerd's default propagation is "rprivate", not "private":
https:/moby/moby/blob/v20.10.23/volume/mounts/linux_parser.go#L145

However, dockerd automatically changes the default propagation to "rslave"
when the mount source contains the daemon root (`/var/lib/docker`):
- https:/moby/moby/blob/v20.10.23/daemon/volumes.go#L137-L143
- https:/moby/moby/blob/v20.10.23/daemon/volumes_linux.go#L11-L36

This behavior was introduced in Docker 18.03 (moby/moby PR 36055).

Signed-off-by: Akihiro Suda <[email protected]>
    @AkihiroSuda
    AkihiroSuda committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    dafa7f8 View commit details
    Browse the repository at this point in the history