-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
encoder updated twice for curl loss #28
Comments
@xy9485 do you know why |
Yeah that's true. I don't know the reason of doing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm looking into the code and find that in
def update_cpc()
bothself.encoder_optimizer.step()
andself.cpc_optimizer.step()
are called. However the parameters ofcritic.encoder
are carried by both optimizer. Isn't it true that, indef update_cpc()
,critic.encoder
is updated twice using the same gradient?The text was updated successfully, but these errors were encountered: