Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-20137] Fix missing job.type in API responses #76

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Oct 4, 2024

Change Summary

There is a field job.type in database table, but it was missing in REST API response schema. Fixed.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.62%. Comparing base (d3b0c17) to head (8b1d1bd).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #76      +/-   ##
===========================================
+ Coverage    90.58%   90.62%   +0.03%     
===========================================
  Files          151      151              
  Lines         2986     2987       +1     
  Branches       276      276              
===========================================
+ Hits          2705     2707       +2     
+ Misses         223      222       -1     
  Partials        58       58              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus merged commit faeea3f into develop Oct 4, 2024
12 checks passed
@dolfinus dolfinus deleted the bugfix/DOP-20137 branch October 4, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants