Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add weights to the explainer #118

Closed
pbiecek opened this issue Oct 17, 2019 · 1 comment
Closed

Add weights to the explainer #118

pbiecek opened this issue Oct 17, 2019 · 1 comment
Assignees
@pbiecek
Labels
before release 📌 TODO before release documentation 📚 Improvements or additions to documentation feature 💡 New feature or enhancement request
Milestone
DALEXverse 0.19.1...

Comments

@pbiecek
Copy link
Member

pbiecek commented Oct 17, 2019

As suggested in #71.
Add the weights filed to the explain() function.
Make it clear that not all explanations support weights and it is up to the explanation to decide how weights are being used.
@pbiecek pbiecek added feature 💡 New feature or enhancement request documentation 📚 Improvements or additions to documentation labels Oct 17, 2019
@pbiecek pbiecek self-assigned this Oct 17, 2019
pbiecek added a commit that referenced this issue Oct 18, 2019
@pbiecek
candidate fix for #118
a6e0c8e
@pbiecek pbiecek added the before release 📌 TODO before release label Dec 28, 2019
@pbiecek
Copy link
Member Author

pbiecek commented Feb 18, 2020

added with a6e0c8e
(but note, that not all explanations support weights)

@pbiecek pbiecek closed this as completed Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pbiecek pbiecek

Labels
before release 📌 TODO before release documentation 📚 Improvements or additions to documentation feature 💡 New feature or enhancement request
Projects
None yet
Milestone
DALEXverse 0.19.10 release fall 2019
Development

No branches or pull requests
1 participant
@pbiecek