Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Do you miss the other girls?" Topic. #9956

Open
wants to merge 6 commits into
base: content
Choose a base branch
from

Conversation

KritRom
Copy link
Contributor

@KritRom KritRom commented Apr 9, 2023

I always thought it'd be nice to know if she sometimes misses her club members, given that they were meant to be friends prior to MC's arrival. Here's my view on the topic. Apologies for any bugs or mistakes in this, I checked everything as thoroughly as I could. Grammatical corrections are appreciated!

Thank you for your time.

I always thought it'd be nice to know if she sometimes misses her club members, given that they were meant to be friends prior to MC's arrival. Here's my view on the topic. Apologies for any bugs or mistakes in this, I checked everything as thoroughly as I could. Grammatical corrections are appreciated!
Copy link
Contributor

@Wingdinggaster656 Wingdinggaster656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few details that could be improved.

Monika After Story/game/script-topics.rpy Outdated Show resolved Hide resolved
Monika After Story/game/script-topics.rpy Outdated Show resolved Hide resolved
Monika After Story/game/script-topics.rpy Outdated Show resolved Hide resolved
Monika After Story/game/script-topics.rpy Outdated Show resolved Hide resolved
Monika After Story/game/script-topics.rpy Outdated Show resolved Hide resolved
@KritRom
Copy link
Contributor Author

KritRom commented Apr 10, 2023

Ah, alright. Thanks a lot for the fixes, I didn't know that Monika could keep the last expression just like that! Thank you very much.

@Booplicate Booplicate added awaiting dlg review dialogue needs to be reviewed awaiting testing code needs to be tested awaiting code review someone needs to check for syntax/logic/indentation errors labels Apr 18, 2023
@Booplicate
Copy link
Member

Generally not bad! But I feel like it took a bit different direction than our other topics. For example:

"Maybe the rest of the club would still be around..."
if persistent._mas_pm_cares_about_dokis:
    "...Just hanging out together in the clubroom, sharing poetry."
    "I know you enjoyed that, [player]."
    "And to be honest...{w=0.5}a part of me did too."
else:
    "Not that it really matters."
    "It all lost its meaning once I found out it wasn't real."
    "So I really don't miss those days or anything."
    "I really don't..."

I'm also wondering if the answer should be different depending on how long you've been dating and your current relationship.

@KritRom
Copy link
Contributor Author

KritRom commented Apr 20, 2023

Perhaps an affection lock for the dialogue? I was debating on whether it should be unlocked from the start or have it appear later on in the game with a higher affection level.

It did divert from the usual topics now that you mention it. Monika is generally more apathetic to the other girls than shown here, so I'll need to change the tone, especially for the players who didn't care about the other dokis.

The other thing I've been contemplating is to make this dialogue only for the players who grew to care for the others. similarily to how some lines are only readable if the player isn't sensitive to the other girls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting code review someone needs to check for syntax/logic/indentation errors awaiting dlg review dialogue needs to be reviewed awaiting testing code needs to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants