Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can: Open in new tab ? for GitHub custom hotkeys #123

Closed
dnknn opened this issue Aug 7, 2020 · 4 comments
Closed

Can: Open in new tab ? for GitHub custom hotkeys #123

dnknn opened this issue Aug 7, 2020 · 4 comments

Comments

@dnknn
Copy link

dnknn commented Aug 7, 2020

Thanks for this tool, it is very easy to use!
208_07115543

  • πŸ’₯ Current issues:

Can only be opened in the current tab.

  • β₯ Expected behavior:

Some lists can be opened in a new tab.

  • ❓ How to achieve:

Add a checkbox to each list : ⬜ or πŸ”² or πŸ—”

Or, edit in JSON.

@Mottie
Copy link
Owner

Mottie commented Aug 7, 2020

Hi @dnknn!

This userscript uses GitHub's built-in hotkey code, and after looking through their documentation & code, I didn't see any way to make it open a page in a new tab. I'd recommend that you open an issue in that repo to get a discussion started on this enhancement.

@dnknn
Copy link
Author

dnknn commented Aug 7, 2020

OK,Thanksβ™ͺ(ο½₯Ο‰ο½₯)οΎ‰

Hi @Mottie see !
There seems to be a solution πŸ”ŒAPIπŸ”Œ ,I can't know the codeπŸ‘‡
github/hotkey#35 (comment)

@Mottie
Copy link
Owner

Mottie commented Aug 8, 2020

Oh, I see... so the link just needs a target... I'll see what I can do.

@Mottie Mottie removed the External label Aug 8, 2020
@Mottie Mottie closed this as completed in 97b2af8 Aug 9, 2020
@dnknn
Copy link
Author

dnknn commented Aug 10, 2020

Very thanks, it works perfectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants