Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE - Mozfest Community Directory #7417

Closed
5 tasks
wilhitem opened this issue Sep 20, 2021 · 9 comments
Closed
5 tasks

FE - Mozfest Community Directory #7417

wilhitem opened this issue Sep 20, 2021 · 9 comments
Assignees

Comments

@wilhitem
Copy link
Collaborator

wilhitem commented Sep 20, 2021

Design team contact

@sabrinang
Torchbox designers from project available via slack:

  • Lindiwe (ux)
  • Jeth (visual design)

Final Designs

Figma - https://www.figma.com/file/2knnwWmmqCXuMyF6WPiOuG/MozFest-Additional-Features?node-id=30%3A317

Details

Front end ticket for #7421

Relates to the existing component - https://foundation.mozilla.org/en/what-we-fund/fellowships-and-awards-directory/
API - https://pulse.mozilla.org/api/index.html
Examples of wagtail currently - https://foundation.mozilla.org/en/docs/how-do-i-wagtail/profiles-from-pulse/

Duplicate existing component and make following changes:

  • Admin can define the tabs to show from a list of Profile Types from Pulse (years to be removed)
  • Add the the Space dropdown will list all spaces of people under current tab

For each card:

  • list spaces

Implementation Checklist

Acceptance Criteria

  • Matches designFilter can be turned off by profile type (keep blank space where it was to avoid content jumping)
  • Navigation is horizontally scrollable on mobile
  • 2 Card grid on desktop
  • 1 card grid on mobile
  • Current tab is highlighted
@jamilasnell jamilasnell added this to the MozFest 2021 TBX milestone Sep 20, 2021
@wilhitem wilhitem changed the title FE - Community Directory FE - Mozfest Community Directory Sep 21, 2021
@wilhitem
Copy link
Collaborator Author

@jamilasnell this one is assigned to @stevedya and was estimated at 3 hours, so maybe mark as a 4?
Steven does appear to have access to the repo, i just can't assign it to him currently.

@jamilasnell
Copy link

jamilasnell commented Oct 7, 2021

Steven is struggling to test this locally, @Pomax would you be able to assist here?

@stevedya
Copy link
Collaborator

stevedya commented Oct 7, 2021

Hey @jamilasnell / @Pomax I was able to get this testing okay locally after a chat with Boggs yesterday :)
I just have a couple questions regarding the filters:

  • Just wanted to confirm the filters above the block in the figma design (Wranglers, Facilitators, Etc) are based off of profile_type in the api?
  • Is there a "space" attribute in the pulse api or would the "Filter by space" drop down be used to filter profiles by program_type or issues?
    Screen Shot 2021-10-07 at 2.52.39 PM.png

@stevedya
Copy link
Collaborator

stevedya commented Oct 7, 2021

Ohh also forgot to ask:

  • Will the Profile Directory Block used on other Mozilla pages use this new filtering?
  • The blue links at the bottom of each card (AI IRL, neurodiversity) I'm curious which field these are connected to in the API as well (i'm guessing they are "issues" connected to the profile)

@marcwalsh
Copy link
Collaborator

Hey @stevedya - I can answer these.

  • Yes, we'll use profile_type for filtering by Wranglers, Facilitators, etc. However, it's only a limited number of options that we want to be displayed.
  • The spaces filter will be by program_type (as that is a field I can add options to)
  • Currently this will only be for the MozFest site, but if it works well we can share it with the Fellows team to see if they would like to implement it.
  • The blue links would be the program_type (space) - but they do not need to link.

@SharmaineLim
Copy link
Contributor

Hey @marcwalsh , about the use of program_type for spaces, what did you have in mind for the profiles with multiple spaces? It looks like currently, each profile can only have one program_type.

@marcwalsh
Copy link
Collaborator

It's very unlikely we'll see profiles with more than one space. Wranglers are only in one space. Facilitators could be in more than one space, but we can ask them to pick the main space for MVP - alternatively create a duplicate profile if they really want to be listed in both.

@SharmaineLim
Copy link
Contributor

Sounds good, thanks Marc!

@richbrennan
Copy link
Contributor

Closing as both PRs related to this issue have been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants