Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format Pulse profile ID as string #7354

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Conversation

TheoChevalier
Copy link
Contributor

@TheoChevalier TheoChevalier commented Sep 10, 2021

Closes #7353

This forces the value to be treated as a string instead of a number, because USE_THOUSAND_SEPARATOR is set to true, and does apply the locale’s formatting rules to numbers.

Test page: https://foundation-s-thousand-s-zekjmo.herokuapp.com/en/campaigns/test-page/

@mofodevops mofodevops temporarily deployed to foundation-s-thousand-s-zekjmo September 10, 2021 12:28 Inactive
@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

Copy link
Contributor

@Pomax Pomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this fixes the symptom, this leaves the original problem in place, so I'd rather we find out why this is templating in with locale number formatting, despite the absence of any filter instructing it to do so.

Copy link
Contributor

@Pomax Pomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as immediate remediation, but we need to turn this behaviour off and be explicit in our templates when we need localised numerical strings - #7355 has been filed to address that.

@Pomax Pomax merged commit 70b0aa3 into master Sep 10, 2021
@Pomax Pomax deleted the thousand-separator-pulse-profile branch September 10, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pulse/Wagtail interface breaking links
3 participants