Resolve Authentication Issues #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good riddance. Thanks!
|
|
NP! |
|
|
||
| mongoose.connect(secrets.db); | ||
| mongoose.connection.on('error', function() { | ||
| console.error('MongoDB Connection Error. Please make sure that MongoDB is running.'); |
There was a problem hiding this comment.
I suspect this entire patch was prompted in order to remove this >80-char line. ;) 👍
There was a problem hiding this comment.
😉 That .. and not a fan of storing OAuth tokens and user email addresses if we don't have to.
|
Tested sign-in sign-out. Works for me. I left a couple comments in code, nothing critical. Yay! |
simonwex
added a commit
that referenced
this pull request
Dec 18, 2014
Resolve Authentication Issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some major changes to the way authentication and sessions are managed by the application. In general, the goal was to simplify the codebase to work exclusively with Github authentication and reduce dependencies. This was acomplished by removing boilerplate, moving to client-side session storage, and eliminating the need for a backing datastore.
Revisions
require-ed in the app itselfnpm testthat includes style and basic route checksResolves