Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NaN equality within Arrays #27

Open
mitches-got-glitches opened this issue Apr 22, 2021 · 2 comments
Open

Add support for NaN equality within Arrays #27

mitches-got-glitches opened this issue Apr 22, 2021 · 2 comments
Labels
good first issue Good for newcomers

Comments

@mitches-got-glitches
Copy link
Contributor

mitches-got-glitches commented Apr 22, 2021

When trying to assert_df_equality with allow_nan_equality=True, if the both DataFrames hold an array that contains some nan values then the comparer fails, even if the nans are in the same place.

An additional check should take place here to compare the array elements.

if allow_nan_equality:
for key in d1.keys() & d2.keys():
if not(nan_safe_equality(d1[key], d2[key])):
return False
return True

Again, I can help contribute to this one but it won't be until next week.

Here's a comparison example:

image

@MrPowers
Copy link
Owner

Yes, this would be a good addition, and no rush, whenever you get around to it! Thanks so much for the help!!

@mitches-got-glitches
Copy link
Contributor Author

Hi @MrPowers , just a note to say I have a pull request on this sitting ready to go. I branched off the changes on #29 though because it made sense to get that one through first. I'm just wondering what your timeline might be for a further review of the impact of #29? Some of the features would be useful to me currently.

@MrPowers MrPowers added the good first issue Good for newcomers label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants