-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for NaN equality within Arrays #27
Comments
Yes, this would be a good addition, and no rush, whenever you get around to it! Thanks so much for the help!! |
Hi @MrPowers , just a note to say I have a pull request on this sitting ready to go. I branched off the changes on #29 though because it made sense to get that one through first. I'm just wondering what your timeline might be for a further review of the impact of #29? Some of the features would be useful to me currently. |
When trying to
assert_df_equality
withallow_nan_equality=True
, if the both DataFrames hold an array that contains somenan
values then the comparer fails, even if thenan
s are in the same place.An additional check should take place here to compare the array elements.
chispa/chispa/row_comparer.py
Lines 16 to 20 in 500793e
Again, I can help contribute to this one but it won't be until next week.
Here's a comparison example:
The text was updated successfully, but these errors were encountered: