Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add allow_nan_equality option to assert_approx_df_equality #29

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Add allow_nan_equality option to assert_approx_df_equality #29

wants to merge 12 commits into from
+268 −210

Commits on Apr 26, 2021

  1. Standardise row comparison by making precision optional 

    The objective of the issue was to make allow_nan_equality available to
assert_approx_df_equality, but on reviewing the code it seemed like a
more efficient plan to include the precision option in
assert_df_equality and make it optional. This results in only one set
of functions needed to be maintained.

I've moved the single assert_rows_equality function into row_comparer
along with the custom exception which I've renamed. I've made one
generic equality function which takes options. All the tests have been
updated although there could be scope for a few more new tests - I
wanted to consult on that first.

This is a fairly large change to the API for which a major version
update would be recommended.
    @mitches-got-glitches
    mitches-got-glitches committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    945443e View commit details
    Browse the repository at this point in the history

  2. Made use of blue function in row/column comparer modules

    @mitches-got-glitches
    mitches-got-glitches committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    b94d4d5 View commit details
    Browse the repository at this point in the history

  3. Spelling fix

    @mitches-got-glitches
    mitches-got-glitches committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    e74368e View commit details
    Browse the repository at this point in the history

  4. Update README examples to reflect assert_df_equality changes 

    Changed the section on assert approx df equality.
    @mitches-got-glitches
    mitches-got-glitches committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    5fe032a View commit details
    Browse the repository at this point in the history

  5. Add changes to asserting approx df equality to Changelog

    @mitches-got-glitches
    mitches-got-glitches committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    958b19c View commit details
    Browse the repository at this point in the history

  6. Change func name equality to check_equal

    @mitches-got-glitches
    mitches-got-glitches committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    34fd432 View commit details
    Browse the repository at this point in the history

  7. Change assert_column_equality to accept optional precision param 

    I've removed assert_approx_column_equality from the API.
    @mitches-got-glitches
    mitches-got-glitches committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    c3b907c View commit details
    Browse the repository at this point in the history

  8. Remove assert_approx_df_equality from the API

    @mitches-got-glitches
    mitches-got-glitches committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    147bb57 View commit details
    Browse the repository at this point in the history

  9. Update README to reflect changes to assert_column_equality

    @mitches-got-glitches
    mitches-got-glitches committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    3ff1f18 View commit details
    Browse the repository at this point in the history

  10. Update Changelog with assert_column_equality changes

    @mitches-got-glitches
    mitches-got-glitches committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    47f900a View commit details
    Browse the repository at this point in the history

  11. Remove test run code at bottom of column_comparer

    @mitches-got-glitches
    mitches-got-glitches committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    461c978 View commit details
    Browse the repository at this point in the history

  12. Remove some unnecessary comments

    @mitches-got-glitches
    mitches-got-glitches committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    0533904 View commit details
    Browse the repository at this point in the history