Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Resolution Library version to 7.1.4 to support L2 minted domains #4300

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jim-unstoppable
Copy link

@jim-unstoppable jim-unstoppable commented Apr 16, 2022

Closes #4312

🎉 🎉 🎉

Description

Unstoppable released an update to the Resolution libraries in late 2021 to support resolution of domains that are minted on Polygon as well as Ethereum. At this time the majority of UD domains are on Polygon, so this is a significant update to allow UD domain holders to use MyCrypto.

Since MyCrypto used the default configuration params of the Resolution Library, all that needs to be done is update the JS library versions. Everything else remains as is, and MyCrypto will now support resolution of these Polygon minted domains.
......

Changes

*Updated unstoppabledomains/resolution dependency in package.json to ^7.1.4

Reusable Code/Components

Steps to Test

  1. Launch app
  2. Go to Send
  3. Connect wallet
  4. Select ETH Asset
  5. For recipient, each of the following domains should resolve to an ETH address (brad.crypto, jim-unstoppable.crypto, jim-unstoppable.wallet). N.B. you do NOT need to send any crypto, just check that the UI presents back an ETH address without error

Zeplin Design

Quality Assurance

  • The branch name is in lowercase-kebab-case with no prefix (unless it was created from Clubhouse)
  • The base branch is develop or gau (no nested branches)
  • This is related to a maximum of one Clubhouse story or GitHub issue
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types)
  • If code is copied from existing directories, there is an explanation of why this is necesary in the description/changes, and all copying is done in separate commits to make them easy to filter out
  • If your code adds new text to the UI, the added text is translatable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Unstoppable Domains Integration To Latest
2 participants