Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] RNS Resolution #4363

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ahsan-javaiid
Copy link

Description

This PR fixes RNS resolution issue on send screen. There are two reasons due to which RNS names are not resolving.

  1. Network is hardcoded in lookup field component here:
    const provider = new ProviderHandler(ethNetwork);
  2. In case of RSK network RPC provider does not know RNS registry address:
    return new StaticJsonRpcProvider(connection, chainId);
    which in case of eth, points to correct address.

Changes

  1. Remove hardcoded network in lookup field component
  2. Set RNS registry address inside provider in case of RSK network

Demo

mycrypto-demo.mp4

Steps to test

  1. Select RSK network
  2. Enter any rns name in the address field
  3. Name should resolve to address

@alepc253
Copy link
Contributor

alepc253 commented Mar 8, 2023

@FrederikBolding could you please take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants