Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADR for CO2 stac api entry #147

Open
wants to merge 1 commit into
base: feature/adrs
Choose a base branch
from
Open

Conversation

slesaad
Copy link
Member

@slesaad slesaad commented Jan 7, 2022

Adds ADR for CO2 dataset for the STAC api

]
]
},
"properties": {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the values which are data the dashboard front end is currently dependent on for rendering tiles should either be omitted for now or part of a custom extension, i.e. https:/NASA-IMPACT/covid-api/blob/adrs/stac-co2/adrs/co2.json#L42-L64 and https:/NASA-IMPACT/covid-api/blob/adrs/stac-co2/adrs/co2.json#L93-L122 should be omitted or use a key indicating a custom extension like "frontend:s3_location"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now have the delta-config to keep in mind as well. It might help if there is metadata that just doesn't fit into any of the predefined attributes in the stac specification.

If I understand correctly, delta config will have more ui-specific metadata about thematic areas and groupings of datasets but it seems like it could also house information like the legend colormap. I'm sure we will need to define at least one custom extension along the way, though, so you may end up needing to mock a custom extension for item properties anyway.

{
"stac_version": "1.0.0",
"stac_extensions": [],
"type": "Feature",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be an STAC example both for the collection (co2) and for specific items (s3://covid-eo-data/xco2-base/xco2_16day_base.2022-01-07.tif, not sure if that's a valid date just an example, but items I think should refer to a single tif asset). I think this example might be trying to do both is that right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second this, I think we need an example of a stac collection document and an item document. I'd be into a working session if we wanted to hash things out over an individual dataset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants